dedupe helpers in buildbarn tests and support restarting - #23583
Open
cburroughs wants to merge 1 commit into
Open
dedupe helpers in buildbarn tests and support restarting#23583cburroughs wants to merge 1 commit into
cburroughs wants to merge 1 commit into
Conversation
This does a few entangled things: * Some minor DRY to the test helpers. * Adds the ability to restart the buildbarn service. The intent here is write tests along the lines of "does feature A work correctly if the cache is wiped/expired between operations X and Y". * Threads through `CACHE_SPECULATION_DELAY_MILLIS` a la #23573 Notice: This preparatory work is extracted from a larger LLM code generated change.
cburroughs
added
the
release-notes:not-required
cburroughs
marked this pull request as ready for review
July 29, 2026 17:30
tobni
reviewed
Jul 29, 2026
|
|
||
| # With the default of 0, Pants starts a remote execution before the cache lookup can answer, | ||
| # so a cached run still counts an execution request. | ||
| _CACHE_SPECULATION_DELAY_MILLIS = 10_000 |
Contributor
There was a problem hiding this comment.
Maybe this can be rehomed, instead of duplicated?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does a few entangled things:
CACHE_SPECULATION_DELAY_MILLISa la test: Attempt to de-flake Buildbarn action cache assertions #23573Notice: This preparatory work is extracted from a larger LLM code generated change.