restore remote_cache_rpc_timeout_millis/remote_cache_rpc_concurrency - #23581
Open
cburroughs wants to merge 1 commit into
Open
restore remote_cache_rpc_timeout_millis/remote_cache_rpc_concurrency#23581cburroughs wants to merge 1 commit into
cburroughs wants to merge 1 commit into
Conversation
In #20115 these inadvertently became ignored (the *store* ones were used instead) once we got from the python options into rust. I opted to keep the default value for `remote_cache_rpc_timeout_millis` that useres had actually been in operations with since 2.19 intead of reverting to the documented value. NOTE: A LLM statically identified this bug while I was trying to make an adjacent change, and generated this fix.
cburroughs
marked this pull request as ready for review
July 29, 2026 17:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #20115 these inadvertently became ignored (the store ones were used instead) once we got from the python options into rust.
I opted to keep the default value for
remote_cache_rpc_timeout_millisthat useres had actually been in operations with since 2.19 intead of reverting to the documented value.NOTE: A LLM statically identified this bug while I was trying to make an adjacent change, and generated this fix.