Skip to content

ALS injector example - #178

Open
qianglbl wants to merge 42 commits into
pals-project:mainfrom
qianglbl:alsinjector
Open

ALS injector example#178
qianglbl wants to merge 42 commits into
pals-project:mainfrom
qianglbl:alsinjector

Conversation

@qianglbl

Copy link
Copy Markdown
Contributor

In a real machine like the ALS injector,
there is a middle layer that contains control variables for the EPICS system.

Where should these variables be placed within PALS?

@qianglbl
qianglbl requested a review from cemitch99 February 11, 2026 22:59
qianglbl and others added 2 commits March 2, 2026 13:50
Co-authored-by: Chad Mitchell <46825199+cemitch99@users.noreply.github.com>
Co-authored-by: Chad Mitchell <46825199+cemitch99@users.noreply.github.com>

@qianglbl qianglbl left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove "length" line for START and END

@qianglbl

qianglbl commented Mar 4, 2026

Copy link
Copy Markdown
Contributor Author

@DavidSagan PALS header added. Also, I don't understand why we should remove "length : 0.0" for the START and END elements?

@qianglbl

qianglbl commented Mar 6, 2026

Copy link
Copy Markdown
Contributor Author

@DavidSagan The two length lines for START and END elements were removed.

@DavidSagan

Copy link
Copy Markdown
Member

@qianglbl It is looking good. The only thing missing now is a Lattice construct:

- ALS_Injector
    kind: Lattice
    branches:
      - LTB

@qianglbl

Copy link
Copy Markdown
Contributor Author

@DavidSagan Thanks and added the Lattice construct.

cemitch99
cemitch99 previously approved these changes Mar 23, 2026
DavidSagan
DavidSagan previously approved these changes Mar 23, 2026
@EZoni

EZoni commented Apr 13, 2026

Copy link
Copy Markdown
Member

@qianglbl

Do we want to include control variable information in this PR? If not, what does this example alone, as is, describe?

@qianglbl
qianglbl dismissed stale reviews from DavidSagan and cemitch99 via 972d654 April 20, 2026 22:27
@qianglbl

Copy link
Copy Markdown
Contributor Author

updated quadrupole values in the ALS injector example.

@cemitch99

Copy link
Copy Markdown
Contributor

Let's change the name of this PR to "ALS injector example" or something similar.

@EZoni EZoni changed the title Control Variables in PALS ALS injector example Jun 15, 2026
@EZoni
EZoni requested review from DavidSagan and cemitch99 June 15, 2026 22:52
@EZoni

EZoni commented Jun 15, 2026

Copy link
Copy Markdown
Member

FYI, I will push a small style change to this branch.

Comment thread examples/alsinj.pals.yaml Outdated
Comment thread examples/alsinj.pals.yaml Outdated
Comment thread examples/alsinj.pals.yaml Outdated
EZoni and others added 2 commits June 15, 2026 16:20
added initial sigma matrix information.
@qianglbl

Copy link
Copy Markdown
Contributor Author

@DavidSagan added initial beam sigma matrix information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants