Repository navigation
Conversation
serializer_kwargs only reached dumps, so codecs like jsonpickle that need the same flag on loads could not round-trip. Store deserializer_kwargs separately because dumps and loads often take different options.
Member
davidism
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
serializer_kwargsonly goes todumps. That's fine forjson.dumps(..., skipkeys=True), whichjson.loadswould reject, but it means something like jsonpickle'skeys=Truecannot round-trip throughSerializer.I didn't forward the same dict to both sides — that's what blows up the existing skipkeys test. New
deserializer_kwargsis stored next to it and passed toloadsinload_payloadwhen using the instance serializer.Fixes #389