Repository navigation
Fix flaky watcher warning coverage - #15
Merged
Merged
Conversation
Co-authored-by: Codex <noreply@openai.com> Co-authored-by: Billo AI <ai-engineering@billo.systems>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The macOS watcher test assumed five invalid save-file replacements would produce five failed parse attempts. Filesystem notification coalescing or delays can break that assumption, leaving no warning even when the recovery assertions pass.
Move consecutive-failure tracking into a private helper used by the real watcher. Deterministic tests cover the fifth-failure boundary, suppression after warning, successful-parse reset and independent streaks. The native integration test retains its invalid-input, no-publication, unchanged-file and exact recovery assertions without counting warnings from filesystem events. The existing warning message and successful-parse reset point are preserved.
Validation, independently reproduced by CDC:
The original CI event was not reproduced exactly; the fix removes the test's unsupported event-count assumption. Hosted cross-platform checks will run on this PR.