Skip to content

Use docker/build-push-action@ in CI instead of upload-docker.sh - #2342

Merged
nvuillam merged 14 commits into
mainfrom
features/docker-build-action
Feb 11, 2023
Merged

Use docker/build-push-action@ in CI instead of upload-docker.sh#2342
nvuillam merged 14 commits into
mainfrom
features/docker-build-action

Conversation

@nvuillam

Copy link
Copy Markdown
Member

No description provided.

@nvuillam

nvuillam commented Feb 11, 2023

Copy link
Copy Markdown
Member Author

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ BASH bash-exec 6 0 0.04s
✅ BASH shellcheck 6 0 0.2s
✅ BASH shfmt 6 0 0 0.43s
✅ COPYPASTE jscpd yes no 3.96s
✅ DOCKERFILE hadolint 105 0 12.38s
✅ JSON eslint-plugin-jsonc 21 0 0 2.82s
✅ JSON jsonlint 19 0 0.4s
✅ JSON v8r 21 0 15.23s
⚠️ MARKDOWN markdownlint 309 0 232 7.76s
✅ MARKDOWN markdown-link-check 309 0 6.23s
✅ MARKDOWN markdown-table-formatter 309 0 0 21.12s
✅ OPENAPI spectral 1 0 2.37s
⚠️ PYTHON bandit 176 45 2.51s
✅ PYTHON black 176 0 0 4.96s
✅ PYTHON flake8 176 0 2.4s
✅ PYTHON isort 176 0 0 0.97s
✅ PYTHON mypy 176 0 10.22s
✅ PYTHON pylint 176 0 14.7s
⚠️ PYTHON pyright 176 276 22.74s
✅ REPOSITORY checkov yes no 36.76s
✅ REPOSITORY git_diff yes no 0.43s
✅ REPOSITORY secretlint yes no 15.36s
✅ REPOSITORY trivy yes no 31.58s
✅ SPELL cspell 729 0 27.09s
✅ SPELL misspell 550 0 0 1.0s
✅ XML xmllint 3 0 0 0.47s
✅ YAML prettier 81 0 0 3.79s
✅ YAML v8r 23 0 73.64s
✅ YAML yamllint 82 0 1.39s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@nvuillam
nvuillam force-pushed the features/docker-build-action branch from 1270e27 to 39fea0b Compare February 11, 2023 00:25
@nvuillam
nvuillam marked this pull request as ready for review February 11, 2023 02:12
@nvuillam

Copy link
Copy Markdown
Member Author

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ BASH bash-exec 6 0 0.01s
✅ BASH shellcheck 6 0 0.16s
✅ BASH shfmt 6 0 0 0.04s
✅ COPYPASTE jscpd yes no 2.78s
✅ DOCKERFILE hadolint 105 0 7.19s
✅ JSON eslint-plugin-jsonc 21 0 0 1.66s
✅ JSON jsonlint 19 0 0.25s
✅ JSON npm-package-json-lint yes no 0.59s
✅ JSON v8r 21 0 12.71s
⚠️ MARKDOWN markdownlint 309 2 232 5.8s
✅ MARKDOWN markdown-link-check 309 0 5.25s
✅ MARKDOWN markdown-table-formatter 309 2 0 14.67s
✅ OPENAPI spectral 1 0 1.6s
⚠️ PYTHON bandit 176 45 2.03s
✅ PYTHON black 176 0 0 3.19s
✅ PYTHON flake8 176 0 1.76s
✅ PYTHON isort 176 0 0 0.53s
✅ PYTHON mypy 176 0 6.62s
✅ PYTHON pylint 176 0 10.36s
⚠️ PYTHON pyright 176 274 15.44s
✅ REPOSITORY checkov yes no 26.23s
⚠️ REPOSITORY devskim yes 61 1.25s
✅ REPOSITORY dustilock yes no 3.47s
✅ REPOSITORY git_diff yes no 0.05s
✅ REPOSITORY secretlint yes no 6.49s
✅ REPOSITORY syft yes no 0.87s
✅ REPOSITORY trivy yes no 15.91s
✅ SPELL cspell 729 0 16.54s
✅ SPELL misspell 550 2 0 0.51s
✅ XML xmllint 3 0 0 0.03s
✅ YAML prettier 81 0 0 2.49s
✅ YAML v8r 23 0 51.9s
✅ YAML yamllint 82 0 1.14s

See detailed report in MegaLinter reports

You could have same capabilities but better runtime performances if you request a new MegaLinter flavor.

MegaLinter is graciously provided by OX Security

@nvuillam
nvuillam merged commit 2c78dd0 into main Feb 11, 2023
@nvuillam
nvuillam deleted the features/docker-build-action branch February 11, 2023 02:47
@bdovaz

bdovaz commented Feb 11, 2023

Copy link
Copy Markdown
Collaborator

@nvuillam congratulations for this great achievement! It will help us to unlock several PRs like #2273 #2299 #2314

@nvuillam

Copy link
Copy Markdown
Member Author

@bdovaz I knew you would like it haha ^^

And it will be a game changer for releases.... until now we always rebuilt the images, so there was 1h between the release (with dependabot & renovate creating automated PRs in repos using MegaLinter), and that provoked issues because the new images were not released yet...

Now we'll just take beta images, retag them & push them, and it is done in 2 mn ^^

@bdovaz

bdovaz commented Feb 11, 2023

Copy link
Copy Markdown
Collaborator

@nvuillam yes, little by little we are getting rid of the technical debt inherited from superlinter in terms of CI and that's really great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants