lists: add conjunction parameter to natural_list (issue #214) - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements python-humanize#214 — an optional
conjunctionparameter onnatural_listchoosing between "and" and "or".What
natural_list(items, conjunction="and")— new keyword;"or"producesone, two or three; any other value raisesValueError.tests/test_lists.pycovering both conjunctions, the empty/single-item edge cases, and the invalid-value rejection.Tests
python -m pytest→ 752 passed, 110 skipped (baseline at this pin: 746 passed).Notes
conjunctionoption tonatural_listpython-humanize/humanize#398 (third-party) already proposes the same parameter and is open — this fork implementation does not race it; recorded here for the fork's own completeness.osalksfork first; upstream submission is a separate decision.