Avoid linking to uninstalled TARGET_OBJECTS - #5157
Merged
Merged
Conversation
As reported in ornladios#5105, the KWSys third-party module was installing a target with files in the `INTERFACE_SOURCES` property that were not installed. Even though this target was never used, CMake was failing simply because the target with a bad property existed. This change modifies how the KWSys module is used. Rather than split objects from the interface, the module creates a single `adios2sys` target and avoids adding target objects. Fixes ornladios#5105
Contributor
Author
mathstuf
approved these changes
Aug 21, 2026
mathstuf
left a comment
mathstuf
left a comment
Contributor
There was a problem hiding this comment.
Assuming CI is happy, yes, this looks like the resolution.
Contributor
Author
|
@vicentebolea Can you review and merge this PR (assuming everything is good)? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported in #5105, the KWSys third-party module was installing a target with files in the
INTERFACE_SOURCESproperty that were not installed. Even though this target was never used, CMake was failing simply because the target with a bad property existed.This change modifies how the KWSys module is used. Rather than split objects from the interface, the module creates a single
adios2systarget and avoids adding target objects.Fixes #5105