Skip to content

ci: exclude JDTLS workspaces from language-server cache - #1788

Merged
opcode81 merged 1 commit into
oraios:mainfrom
TyceHerrman:agent/jdtls-cache-immutable
Aug 8, 2026
Merged

ci: exclude JDTLS workspaces from language-server cache#1788
opcode81 merged 1 commit into
oraios:mainfrom
TyceHerrman:agent/jdtls-cache-immutable

Conversation

@TyceHerrman

@TyceHerrman TyceHerrman commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Summary

  • keep caching downloaded language-server installations
  • exclude JDTLS project workspaces from the shared GitHub Actions cache
  • force each CI job to initialize its own Eclipse/Buildship runtime state

Why

Serena currently caches all of ~/.serena/language_servers/static, including
EclipseJDTLS/workspaces. Those directories contain mutable, project-specific
Eclipse and Buildship state. Restoring that state into another job can make Java
test behavior depend on an earlier job rather than only on the checked-out
revision and current runner.

This is an independent cache-correctness change. It does not claim that restored
workspace state caused the Windows JDTLS hang; the diagnostics work in #1786 is
still needed to classify that stall.

The cache action supports multiple glob paths and leading ! exclusions. Its
cache version also incorporates the configured paths, so the new definition
does not match the old broad cache archive.

#1214 intentionally preserves JDTLS workspaces across local Serena restarts. #1576 established stale JDTLS workspace state as a real correctness risk. This change preserves that user behavior while preventing GitHub Actions from restoring project-derived workspace state across revisions that share the same runner checkout path.

Validation

  • workflow YAML parses successfully
  • git diff --check
  • actionlint reports only diagnostics already present on main

@opcode81

opcode81 commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Is this ready?

@TyceHerrman

Copy link
Copy Markdown
Contributor Author

Not yet I need to review it further still

@TyceHerrman
TyceHerrman force-pushed the agent/jdtls-cache-immutable branch from a5ffe8b to 17ede7a Compare August 4, 2026 17:53
@TyceHerrman
TyceHerrman marked this pull request as ready for review August 4, 2026 19:28
@TyceHerrman

Copy link
Copy Markdown
Contributor Author

@opcode81 this is ready for review now afaik

@TyceHerrman
TyceHerrman force-pushed the agent/jdtls-cache-immutable branch from 17ede7a to 9299056 Compare August 6, 2026 18:34
@opcode81 opcode81 closed this Aug 8, 2026
@opcode81 opcode81 reopened this Aug 8, 2026
@oraios oraios deleted a comment from TyceHerrman Aug 8, 2026
@opcode81

opcode81 commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

@TyceHerrman sorry, I had accidentally closed the wrong PR.

@opcode81
opcode81 merged commit 7acd78b into oraios:main Aug 8, 2026
24 checks passed
@opcode81

opcode81 commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants