ci: exclude JDTLS workspaces from language-server cache - #1788
Merged
Conversation
This was referenced Jul 31, 2026
Contributor
|
Is this ready? |
Contributor
Author
|
Not yet I need to review it further still |
TyceHerrman
force-pushed
the
agent/jdtls-cache-immutable
branch
from
August 4, 2026 17:53
a5ffe8b to
17ede7a
Compare
TyceHerrman
marked this pull request as ready for review
August 4, 2026 19:28
Contributor
Author
|
@opcode81 this is ready for review now afaik |
TyceHerrman
force-pushed
the
agent/jdtls-cache-immutable
branch
from
August 6, 2026 18:34
17ede7a to
9299056
Compare
Contributor
|
@TyceHerrman sorry, I had accidentally closed the wrong PR. |
Contributor
|
Thanks for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Serena currently caches all of
~/.serena/language_servers/static, includingEclipseJDTLS/workspaces. Those directories contain mutable, project-specificEclipse and Buildship state. Restoring that state into another job can make Java
test behavior depend on an earlier job rather than only on the checked-out
revision and current runner.
This is an independent cache-correctness change. It does not claim that restored
workspace state caused the Windows JDTLS hang; the diagnostics work in #1786 is
still needed to classify that stall.
The cache action supports multiple glob paths and leading
!exclusions. Itscache version also incorporates the configured paths, so the new definition
does not match the old broad cache archive.
#1214 intentionally preserves JDTLS workspaces across local Serena restarts. #1576 established stale JDTLS workspace state as a real correctness risk. This change preserves that user behavior while preventing GitHub Actions from restoring project-derived workspace state across revisions that share the same runner checkout path.
Validation
git diff --checkactionlintreports only diagnostics already present onmain