Svelte test fixture: remove unused demo dependencies - #1707
Open
xormania wants to merge 2 commits into
Open
Conversation
Drop the SvelteKit demo-template baggage that no test exercises: @fontsource/fira-mono, @neoconfetti/svelte, @tailwindcss/vite and tailwindcss, along with their only usages (the layout.css imports, the sverdle page's confetti effect, and the tailwind vite plugin). A regenerated lockfile shrinks from 119 to 91 package entries (-24%). rolldown and lightningcss remain: they are vite's own dependencies, not tailwind's. Test-relevant files are untouched: tests reference the sverdle page only as an expected member of reference/rename result sets, and its $lib imports (game.ts, Words.svelte) are preserved. Verified: clean npm install + svelte-kit sync + full svelte suite (16/16) against the trimmed fixture. Note: oraios#1648 commits a package-lock.json generated from the previous dependency set; whichever change lands second must regenerate it.
The lockfile merged in oraios#1648 was generated from the untrimmed package.json. With this branch's dependency trim, the stale lockfile would make the fixture's `npm ci` fail its integrity check, and the svelte suite would silently skip instead of running (npm ci failure surfaces as pytest.skip). Regenerated from the trimmed package.json (58 packages, down from the untrimmed set) and verified: `svelte-kit sync` clean, svelte suite 16/16 locally against the regenerated lockfile.
2 tasks
Contributor
Author
|
@MischaPanch out of draft and ready for review (finalized after #1648's lockfile coupling — details in the description). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes SvelteKit demo-template dependencies that no test exercises:
@fontsource/fira-mono,@neoconfetti/svelte,@tailwindcss/vite, andtailwindcss, plus their only usages (thelayout.cssimports, the sverdle page's confetti effect, and the tailwind plugin invite.config.ts).Why
npm ci/svelte-kit syncbootstrap.rolldown/lightningcssstay: they are vite's own dependencies, not tailwind's.Why the second commit regenerates the lockfile
The lockfile merged in #1648 was generated from the untrimmed
package.json. Left as-is, the trimmed fixture'snpm ciwould fail its integrity check — and the svelte suite would silently skip instead of failing (npm cifailure surfaces aspytest.skip, so CI stays green while testing nothing). Regenerating from the trimmedpackage.jsoncloses that gap.Test safety
$libimports that put it there (game.ts,Words.svelte) are untouched.npm install+svelte-kit sync, svelte suite 16/16 against the regenerated lockfile.Checklist
CONTRIBUTING.mdregarding the scope of PRs.CHANGELOG.md, which concisely describes the change. (n/a — test-fixture-only change, no user-facing behavior.)