Trace Unsafe field offsets in native-image agent - #14205
Open
rotilho wants to merge 1 commit into
Open
Conversation
Trace jdk.internal.misc.Unsafe.objectFieldOffset(Field), which atomic field updaters use, while suppressing the duplicate event produced when sun.misc.Unsafe delegates to it. Add real-agent metadata and raw-event coverage for reflection, atomic updaters, and the public Unsafe wrapper.
|
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trace
jdk.internal.misc.Unsafe.objectFieldOffset(Field), which atomic field updaters use, while suppressing the duplicate event produced whensun.misc.Unsafedelegates to it.Add real-agent metadata and raw-event coverage for reflection, atomic updaters, and the public Unsafe wrapper.
Summary
On GraalVM 25, atomic field updater construction can resolve a field through
jdk.internal.misc.Unsafe.objectFieldOffset(Field)without executing the ordinary reflective field-access hooks. The tracing agent therefore omits the target field from reachability metadata, and a native image built with that metadata can fail withMissingReflectionRegistrationError.This change traces the JDK-internal
objectFieldOffset(Field)path while preserving the existing by-name Unsafe handling.When public
sun.misc.Unsafe.objectFieldOffset(Field)delegates to the internal method, the internal event is suppressed precisely for that wrapper call. The existing public event remains responsible for recording the field, preventing duplicate events while preserving the application caller and origin.Ordinary reflective field-access tracing is unchanged.
Related Issues
Testing
The following checks passed:
SVM_AGENTandcom.oracle.svm.configure.test.SVM_TESTS.mx gate --tags condconfigmx checkstylegit diff --checkThe regression coverage verifies:
sun.misc.Unsafe.objectFieldOffset(Field)records the target field;Documentation
No documentation updates are needed. This corrects internal tracing-agent coverage and does not introduce or change a public option, API, or metadata format.
Contributor Checklist