Improve native-image agent ZIP resource tracing - #14204
Open
rotilho wants to merge 1 commit into
Open
Conversation
Place the ZipFile.getEntry breakpoint at its private getZipEntry invocation so it runs only after a successful lookup. This avoids JVMTI events for failed lookups and for stream or enumeration paths while preserving direct resource metadata and caller origins. Add real-agent coverage for successful, missing, and streamed ZIP entries.
|
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Place the
ZipFile.getEntrybreakpoint at its privategetZipEntryinvocation so it runs only after a successful lookup. This avoids JVMTI events for failed lookups and for stream or enumeration paths while preserving direct resource metadata and caller origins.Add real-agent coverage for successful, missing, and streamed ZIP entries.
Summary
The Native Image tracing agent currently places a breakpoint at the entry of
ZipFile.getEntry(String). Consequently, every lookup crosses a JVMTI breakpoint, including unsuccessful probes that do not produce resource metadata. Framework workloads can perform many thousands of such probes.This change dynamically locates the
getZipEntry(String, int)invocation inside publicZipFile.getEntry(String)and installs the breakpoint at that bytecode location. The JDK reaches this invocation only after finding the requested entry.This means:
ZipFile.getEntry(String)calls retain the existing resource trace operation, metadata, caller attribution, and origin stack;ZipFile.stream(),JarFile.stream(), and enumeration paths do not cross the breakpoint or produce incidental resource metadata;Related Issues
Field.getorField.settracing.Testing
The following checks passed:
SVM_AGENTandcom.oracle.svm.configure.test.SVM_TESTS.mx gate --tags condconfigmx checkstylegit diff --checkPerformance validation with 25,000 operations:
An end-to-end Spring Petclinic tracing-agent comparison improved from 324.82 seconds to 122.47 seconds, a 62.3% reduction. Generated resource metadata remained exactly equal at 840 entries in both runs.
A focused origins test confirmed that successful direct lookup metadata remains attributed to the application caller through public
ZipFile.getEntry, without exposing the private helper frame.Documentation
No documentation updates are needed. This changes an internal tracing-agent interception point while preserving the existing resource tracing protocol and user-visible configuration.
Contributor Checklist