Repository navigation
feat(infrahub)!: remove the NATS subchart - #115
Draft
fatih-acar wants to merge 1 commit into
Draft
fatih-acar wants to merge 1 commit into
fatih-acar wants to merge 1 commit into
Conversation
opsmill/infrahub#11210 removes the NATS driver for the message bus and the cache, so the chart no longer installs the `nats` subchart or accepts `nats` values. No template read them: enabling `nats` only deployed a NATS server, which Infrahub used when the operator also set `INFRAHUB_BROKER_DRIVER` or `INFRAHUB_CACHE_DRIVER` to `nats`. With default values the rendered manifests do not change. A release that sets `nats.enabled: true` loses the NATS server on upgrade. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
INFRAHUB_BROKER_DRIVERorINFRAHUB_CACHE_DRIVERtonatsfails to load. Theinfrahubchart still offers anatssubchart, version 1.1.12, thatnats.enabledturns on. (Chart.yamlonstable,values.yamlonstable)infrahubchart fromstable, so merging this pull request earlier would remove the subchart for an Infrahub version that still acceptsnats.What changed
charts/infrahub/Chart.yaml: thenatsdependency is removed.charts/infrahub/values.yaml: thenatsblock (enabled: false,config.jetstream.enabled: true) is removed.charts/infrahub/README.md: the dependency row and the twonats.*value rows are removed by hand.helm-docsproduces the same rows; it would also change theprefectTagrow from 1.11.4 to 1.11.9, which was out of date before this change and is left as is.tests/e2e/test_tracing_optout.py:nats.enabled: falseis removed from the values that trim the stack.AGENTS.md: theinfrahubchart description no longer lists NATS.removed, incharts/infrahub/changelog/andcharts/infrahub-enterprise/changelog/. Theinfrahub-enterprisechart gets this change when itsinfrahubpin moves to a release of theinfrahubchart that contains it.No template read the
natsvalues. Enablingnatsonly deployed a NATS server, which Infrahub used when the operator also setINFRAHUB_BROKER_DRIVERorINFRAHUB_CACHE_DRIVERtonats.How to test
Results:
make lintpasses for every chart.helm templaterenders the same manifests asstable, apart from the RabbitMQ Erlang cookie, which the subchart generates at random on each render.nats.enabled=true,stablerenders 48 objects and this branch renders 40, the same as with default values. Helm accepts the leftovernatsvalue without an error.charts/infrahub/andtests/.Impact and rollout
nats.enabled: true(infrahub.nats.enabled: truewithinfrahub-enterprise) loses the NATS server when the chart is upgraded. If that release setINFRAHUB_BROKER_DRIVERorINFRAHUB_CACHE_DRIVERtonats, it must switch to RabbitMQ and Redis first. The changelog fragments say so.🤖 Generated with Claude Code