Conversation
* code cleanup * python3 and augmaker graphtool and code cleanup * closes Issue#22 * updates log file name * removes unused imports * more formatting changes and additional comments
Unify my fork and this project
wmdietl
requested changes
Jun 18, 2023
|
|
||
| from . import common | ||
|
|
||
| from . import common |
Member
There was a problem hiding this comment.
This is a duplicate of the line above.
Member
There was a problem hiding this comment.
Is this adding an empty file? Why?
| import copy | ||
| import os | ||
|
|
||
| from . import common |
| '--logLevel=INFO', | ||
| '--jaifFile', jaif_file] | ||
|
|
||
| if args.inPlace: |
Member
There was a problem hiding this comment.
Can you carefully go through the current logic and make sure nothing is lost?
Isn't --inPlace still an option?
Collaborator
Author
There was a problem hiding this comment.
thanks! I think we need to undo this change.
al3xliu
commented
Jul 28, 2023
|
|
||
| ## other_args is other command-line arguments to javac. | ||
| ## brought this from github.com/kelloggm/do-like-javac | ||
| def get_arguments_by_version(jdk_version, other_args = None): |
Collaborator
Author
There was a problem hiding this comment.
compare with two cases, and see whether this is meaningful and keep only one.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.