Skip to content

Define explicit controller names for OP elements - #481

Merged
myabc merged 3 commits into
mainfrom
code-maintenance/explicit-controller-names
Jun 22, 2026
Merged

Define explicit controller names for OP elements#481
myabc merged 3 commits into
mainfrom
code-maintenance/explicit-controller-names

Conversation

@myabc

@myabc myabc commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

Follows upgrade to Catalyst v1.8.0 and addition of explicit controller
names in 0ebf631. This should resolve issues with incorrectly derived
controller names when minified in production builds (e.g. with esbuild).

See also github/catalyst#330

Copilot AI review requested due to automatic review settings June 18, 2026 21:33
@changeset-bot

changeset-bot Bot commented Jun 18, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 0aabd1a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@myabc myabc added maintenance Keeping the fork up do date with the base repo needs review Needs review labels Jun 18, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates OpenProject-specific Catalyst-based custom elements to use explicit controller names, aligning with Catalyst v1.8.0’s support for named controllers and avoiding incorrect name derivation in production/minified builds.

Changes:

  • Add explicit @controller('<name>') identifiers to multiple OpenProject custom element controllers.
  • Standardize controller identifiers to kebab-case names corresponding to the custom element tags used in templates.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
app/components/primer/open_project/zen_mode_button.ts Adds an explicit Catalyst controller name for the zen mode button element.
app/components/primer/open_project/sub_header_element.ts Adds an explicit Catalyst controller name for the sub-header element.
app/components/primer/open_project/page_header_element.ts Adds an explicit Catalyst controller name for the page-header element.
app/components/primer/open_project/filterable_tree_view.ts Adds an explicit Catalyst controller name for the filterable-tree-view element.
app/components/primer/open_project/danger_dialog_form_helper.ts Adds an explicit Catalyst controller name for the danger-dialog-form-helper element.
app/components/primer/open_project/collapsible_section.ts Adds an explicit Catalyst controller name for the collapsible-section element.
app/components/primer/open_project/border_box/collapsible_header.ts Adds an explicit Catalyst controller name for the collapsible-header element.
app/components/primer/open_project/avatar_fallback.ts Adds an explicit Catalyst controller name for the avatar-fallback element.

Comment thread app/components/primer/open_project/zen_mode_button.ts Outdated
@myabc
myabc force-pushed the code-maintenance/explicit-controller-names branch from 4784d76 to 1db903e Compare June 18, 2026 21:44
@myabc myabc added the skip changeset For PRs that contain no relevant release data (e.g. documentation only) label Jun 18, 2026
@myabc
myabc requested a review from HDinger June 18, 2026 21:45
@github-actions

github-actions Bot commented Jun 18, 2026

Copy link
Copy Markdown

⚠️ Visual or ARIA snapshot differences found

Our visual and ARIA snapshot tests found UI differences. Please review the differences by viewing the files changed tab to ensure that the changes were intentional.

Review differences

myabc added 2 commits June 20, 2026 21:05
Follows upgrade to Catalyst v1.8.0 and addition of explicit controller
names in 0ebf631. This should resolve issues with incorrectly derived
controller names when minified in production builds (e.g. with esbuild).

See also github/catalyst#330
@myabc
myabc force-pushed the code-maintenance/explicit-controller-names branch from 1b11913 to 84f6186 Compare June 20, 2026 19:05
@myabc
myabc force-pushed the code-maintenance/explicit-controller-names branch from 57d0e74 to 84f6186 Compare June 22, 2026 17:10
@myabc
myabc merged commit f1e6aee into main Jun 22, 2026
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Keeping the fork up do date with the base repo needs review Needs review skip changeset For PRs that contain no relevant release data (e.g. documentation only)

Development

Successfully merging this pull request may close these issues.

3 participants