Define explicit controller names for OP elements - #481
Conversation
|
There was a problem hiding this comment.
Pull request overview
This PR updates OpenProject-specific Catalyst-based custom elements to use explicit controller names, aligning with Catalyst v1.8.0’s support for named controllers and avoiding incorrect name derivation in production/minified builds.
Changes:
- Add explicit
@controller('<name>')identifiers to multiple OpenProject custom element controllers. - Standardize controller identifiers to kebab-case names corresponding to the custom element tags used in templates.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| app/components/primer/open_project/zen_mode_button.ts | Adds an explicit Catalyst controller name for the zen mode button element. |
| app/components/primer/open_project/sub_header_element.ts | Adds an explicit Catalyst controller name for the sub-header element. |
| app/components/primer/open_project/page_header_element.ts | Adds an explicit Catalyst controller name for the page-header element. |
| app/components/primer/open_project/filterable_tree_view.ts | Adds an explicit Catalyst controller name for the filterable-tree-view element. |
| app/components/primer/open_project/danger_dialog_form_helper.ts | Adds an explicit Catalyst controller name for the danger-dialog-form-helper element. |
| app/components/primer/open_project/collapsible_section.ts | Adds an explicit Catalyst controller name for the collapsible-section element. |
| app/components/primer/open_project/border_box/collapsible_header.ts | Adds an explicit Catalyst controller name for the collapsible-header element. |
| app/components/primer/open_project/avatar_fallback.ts | Adds an explicit Catalyst controller name for the avatar-fallback element. |
4784d76 to
1db903e
Compare
|
Follows upgrade to Catalyst v1.8.0 and addition of explicit controller names in 0ebf631. This should resolve issues with incorrectly derived controller names when minified in production builds (e.g. with esbuild). See also github/catalyst#330
1b11913 to
84f6186
Compare
57d0e74 to
84f6186
Compare
Follows upgrade to Catalyst v1.8.0 and addition of explicit controller
names in 0ebf631. This should resolve issues with incorrectly derived
controller names when minified in production builds (e.g. with esbuild).
See also github/catalyst#330