Round instead of truncate when formatting a duration from hours - #24776
Open
jtauschl wants to merge 1 commit into
Open
Round instead of truncate when formatting a duration from hours#24776jtauschl wants to merge 1 commit into
jtauschl wants to merge 1 commit into
Conversation
format_duration_from_hours passed its computed seconds value straight into Duration.new(seconds: ...), whose hash-based constructor (in the ruby-duration gem) truncates via Float#to_i rather than rounding -- e.g. 5.501 hours (19803.6 seconds) silently serialized as "PT5H30M3S" instead of the correctly rounded "PT5H30M4S", losing up to just under a second of precision on any value with a fractional-second remainder. This affects every caller of this shared formatter (work packages, meetings, time entries), not just time entries. Round the seconds value explicitly before constructing the Duration.
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
recheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes OP-19969.
format_duration_from_hourspassed its computed seconds value straight intoDuration.new(seconds: ...), whose hash-based constructor (in theruby-durationgem) truncates viaFloat#to_irather than rounding -- e.g. 5.501 hours (19803.6 seconds) silently serialized as"PT5H30M3S"instead of the correctly rounded"PT5H30M4S", losing up to just under a second of precision on any value with a fractional-second remainder. This affects every caller of this shared formatter (work packages, meetings, time entries), not just time entries.Change
Round the seconds value explicitly before constructing the
Duration.Test plan
format_duration_from_hours(5.501)→"PT5H30M3S"; after the fix →"PT5H30M4S", andPOST /api/v3/time_entrieswithhours: "PT5H30M3.6S"correctly returns"hours":"PT5H30M4S"