Fix 500 when creating a meeting outcome with an invalid kind - #24771
Open
jtauschl wants to merge 1 commit into
Open
Fix 500 when creating a meeting outcome with an invalid kind#24771jtauschl wants to merge 1 commit into
jtauschl wants to merge 1 commit into
Conversation
MeetingOutcome's kind enum was declared without validate: true, so assigning an unrecognized value raised a raw Rails ArgumentError instead of a normal ActiveModel validation error, propagating uncaught through the API endpoint as a 500. Add validate: true to the enum declaration -- Rails then rejects an out-of-enum value through the usual validation path, returning a clean 422.
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
recheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes OP-19964.
MeetingOutcome'skindenum was declared withoutvalidate: true, so assigning an unrecognized value raised a raw RailsArgumentErrorinstead of a normalActiveModelvalidation error, propagating uncaught through the API endpoint as a 500.Change
Add
validate: trueto the enum declaration -- Rails then rejects an out-of-enum value through the usual validation path, returning a clean 422.Test plan
kind, and that no outcome is createdkind→ 500; after the fix → 422 ("Kind is not set to one of the allowed values."); a validkindstill creates successfully