Skip to content

[SSI-469] increase collection limit to 1000 for sharepoint #24747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kharonus wants to merge 2 commits into
base: release/17.8
Choose a base branch
from
+10 −6
Open

[SSI-469] increase collection limit to 1000 for sharepoint #24747

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7976cf
[SSI-469] increase collection limit to 1000 for sharepoint
Kharonus Aug 14, 2026
0df0231
[SSI-469] fix rubocop
Kharonus Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions modules/storages/app/common/storages/adapters/providers/one_drive/queries/files_query.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,9 @@ module Providers
module OneDrive
module Queries
class FilesQuery < Base
FIELDS = "?$select=id,name,size,webUrl,lastModifiedBy,createdBy,fileSystemInfo,file,folder,parentReference"
MAXIMUM = 1000
FIELDS = "id,name,size,webUrl,lastModifiedBy,createdBy,fileSystemInfo,file,folder,parentReference"
QUERY = "?$top=#{MAXIMUM}&$select=#{FIELDS}".freeze

def initialize(*)
super
Expand All @@ -45,7 +47,7 @@ def call(auth_strategy:, input_data:)
with_tagged_logger do
info "Getting data on all files under folder '#{input_data.folder}'"
Authentication[auth_strategy].call(storage: @storage) do |http|
handle_response(http.get(children_url_for(input_data.folder) + FIELDS)).bind do |response|
handle_response(http.get(children_url_for(input_data.folder) + QUERY)).bind do |response|
files = response.fetch(:value, [])
return empty_response(http, input_data.folder) if files.empty?

Expand Down Expand Up @@ -85,7 +87,7 @@ def storage_files(json_files)
end

def empty_response(http, folder)
handle_response(http.get(location_url_for(folder) + FIELDS)).bind do |response|
handle_response(http.get(location_url_for(folder) + QUERY)).bind do |response|
empty_storage_files(folder.path, response[:id])
end
end
Expand Down
8 changes: 5 additions & 3 deletions ...ages/app/common/storages/adapters/providers/sharepoint/queries/internal/children_query.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,9 @@ module Sharepoint
module Queries
module Internal
class ChildrenQuery < Base
FIELDS = "?$select=id,name,size,webUrl,lastModifiedBy,createdBy,fileSystemInfo,file,folder,parentReference"
MAXIMUM = 1000
FIELDS = "id,name,size,webUrl,lastModifiedBy,createdBy,fileSystemInfo,file,folder,parentReference"
QUERY = "?$top=#{MAXIMUM}&$select=#{FIELDS}".freeze

def self.call(storage:, http:, drive_id:, location:)
new(storage).call(drive_id:, http:, location:)
Expand All @@ -47,7 +49,7 @@ def initialize(storage)
end

def call(http:, drive_id:, location:)
handle_response(http.get(request_uri(drive_id, location) + FIELDS)).bind do |json|
handle_response(http.get(request_uri(drive_id, location) + QUERY)).bind do |json|
files = json.fetch(:value, [])
return empty_response(http, drive_id, location) if files.empty?

Expand Down Expand Up @@ -107,7 +109,7 @@ def parse_response(json)
end

def empty_response(http, drive_id, folder)
handle_response(http.get(folder_uri(drive_id, folder) + FIELDS)).bind do |json|
handle_response(http.get(folder_uri(drive_id, folder) + QUERY)).bind do |json|
if folder.root?
build_empty_root_folder(json)
else
Expand Down
Loading