Fixing PgbackrestRetention.History processing

[bmironov]

Hi @Agalin ,

I believe this Pull Request fixes Issue #35 . The actual issue was in a way of processing .retention.History in internal/pgbackrest/command/commandbuilder.go:143. On top of this line I've also added a few tests to cover this area.

Please accept at your convenience.

Best regards,
Boris

[Agalin]

Thanks for the fix, looks promising.

[Agalin]

Commit lint doesn't like your commit message:

[commitlint] ⧗   input: Fixing PgbackrestRetention.History processing
[commitlint] ✖   subject may not be empty [subject-empty]
[commitlint] ✖   type may not be empty [type-empty]
[commitlint] ✖   message must be signed off [signed-off-by]
[commitlint] ⚠   body may not be empty [body-empty]
[commitlint] ⚠   references may not be empty [references-empty]

Should be something like this: fix: processing of PgbackrestRetention.History (#35).

Also commit must be signed off.

[Agalin]

Thanks for adding the signed off section. It still won't pass the type and subject checks.

[bmironov]

Hi @Agalin ,

I'm confused now. What does this linter want? I've provided type, lower-case starting subject, sign-off, and even message body.

Best regards,
Boris

[Agalin]

It wants you to squash everything. 🙂 Goes through each commit and found some not matching rules.

Try squashing everything with this as the commit header / first line:

fix: parsing PgbackrestRetention.History (#43)

It should pass for all rules related to the first line. Rest of the commit was fine already.

[bmironov]

You mean squash several commits into one OR basically remove message body and leave subject with type and sign-off?

[Agalin]

Not or. Squash to a single commit that has a valid first line (I've fixed the example of a valid line, not sure where did [ ] come from).

Its body is always acceptable as long as it includes the signed-off line (empty body generates only a warning). For example, this commit contains a valid body.

Linter is really careful because those commits are then used to generate release notes and to determine version bumps.

[bmironov]

squashed everything as much as possible