Skip to content

net-snmp: fix linking issue on libnetsnmptrapd - #30262

Open
AuthorReflex wants to merge 1 commit into
openwrt:masterfrom
AuthorReflex:net-snmp-5.9.5.2
Open

net-snmp: fix linking issue on libnetsnmptrapd#30262
AuthorReflex wants to merge 1 commit into
openwrt:masterfrom
AuthorReflex:net-snmp-5.9.5.2

Conversation

@AuthorReflex

@AuthorReflex AuthorReflex commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

📦 Package Details

Maintainer: @stintel

Description:
The new version of the compiler imposes stricter requirements — specifically, it disallows linking against undefined functions. Consequently, the build fails when using the new version. A patch from Debian repository has been added
to fix this issue.

Discussion on main repository: net-snmp/net-snmp#434


🧪 Run Testing Details

  • OpenWrt Version: trunk
  • OpenWrt Target/Subtarget: mediatek/mt7622, ramips/mt76x8
  • OpenWrt Device: Xiaomi Redmi AX6s, Zyxel Keenetic Extra II

✅ Formalities

  • I have reviewed the CONTRIBUTING.md file for detailed contributing guidelines.

If your PR contains a patch:

  • It can be applied using git am
  • It has been refreshed to avoid offsets, fuzzes, etc., using
    make package/<your-package>/refresh V=s
  • It is structured in a way that it is potentially upstreamable
    (e.g., subject line, commit description, etc.)
    We must try to upstream patches to reduce maintenance burden.

@openwrt

openwrt Bot commented Aug 12, 2026

Copy link
Copy Markdown

Formality Check: Failed

We checked this pull request against the contribution guidelines. Here is what needs your attention:

🛑 CRITICAL ERRORS

Commit f5a6b5a - net-snmp: fix linking issue on libnetsnmptrapd:

  • Embedded patch file 'net/net-snmp/patches/140-debian-makefile_trap_needs_agent.patch' violates standard guidelines. Missing required Git header parameters ('From Mon Sep 17 00:00:00 2001' / 'From:' / 'Date:' / 'Subject:') to ensure 'git am' application compatibility

Tip

Do not close this pull request to make corrections. Instead, modify your existing commits (e.g. git commit --amend) and update the branch using git push --force-with-lease --force-if-includes. The checks will re-run automatically.


Something broken? Consider reporting an issue.
Running version 0e15d1c deployed on 2026-08-12 22:36:32 CEST

@AuthorReflex
AuthorReflex marked this pull request as ready for review August 12, 2026 10:49

@openwrt-ai openwrt-ai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit checks

  • 5069eaa "net-snmp: fix linking issue on libnetsnmptrapd" — the message matches the diff (patch added + PKG_RELEASE bump). nit: the body reads "especifically"; the PR description has the same sentence as "specifically". Worth correcting while you amend for the patch-header rework.

Nothing here looks like it blocks a merge. The change itself checks out: PKG_RELEASE goes 2 → 3, which is what a new patch requires; USEAGENTLIBS is already an established variable in apps/Makefile.in (the snmppcap link rule in the hunk context uses it), so the added reference resolves; and the extra agent libraries are already shipped by libnetsnmp-nossl/libnetsnmp-ssl (libnetsnmp{,agent,helpers,mibs}.so.*), which snmptrapd-* depends on, so libnetsnmptrapd.so gains no unsatisfied runtime dependency. All twelve Feeds Package Test Build targets are green, which also confirms the patch applies without fuzz.

Two optional nits inline on the new patch file.


Generated by Claude Code

Comment thread net/net-snmp/patches/140-debian-makefile_trap_needs_agent.patch Outdated
Comment thread net/net-snmp/patches/140-debian-makefile_trap_needs_agent.patch
@AuthorReflex
AuthorReflex force-pushed the net-snmp-5.9.5.2 branch 2 times, most recently from 1d1b34a to 359dca5 Compare August 13, 2026 09:25
The new version of the compiler imposes stricter requirements — specifically,
it disallows linking against undefined functions. Consequently, the build fails
when using the new version. A patch from Debian repository has been added
to fix this issue.

Discussion on main repository: net-snmp/net-snmp#434

Signed-off-by: Ivan Pavlov <AuthorReflex@gmail.com>

@openwrt-ai openwrt-ai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 new commit; no new issues found.

The force-push addresses both nits from the previous round: the patch is renamed to 140-debian-makefile_trap_needs_agent.patch, which now matches the 1x0-debian-* numbering its siblings use (100-debian-statistics, 110-debian-makefiles, 120-debian-searchdirs, 130-debian-extramibs), and the libnetsnmpagetlibnetsnmpagent typo plus the trailing whitespace in the DEP-3 header are fixed. The upstream issue link was added to the patch header, and especificallyspecifically is corrected in the commit message, which otherwise still matches the diff (patch added, PKG_RELEASE 2 → 3).

The functional hunk is unchanged from what I reviewed at 5069eaa, and all ten Feeds Package Test Build targets are green on this head.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants