net-snmp: fix linking issue on libnetsnmptrapd - #30262
Conversation
Formality Check: FailedWe checked this pull request against the contribution guidelines. Here is what needs your attention: 🛑 CRITICAL ERRORS
Tip Do not close this pull request to make corrections. Instead, modify your existing commits (e.g. Something broken? Consider reporting an issue. |
e5bfa8d to
195c2d6
Compare
195c2d6 to
5069eaa
Compare
openwrt-ai
left a comment
There was a problem hiding this comment.
Commit checks
- 5069eaa "net-snmp: fix linking issue on libnetsnmptrapd" — the message matches the diff (patch added +
PKG_RELEASEbump). nit: the body reads "especifically"; the PR description has the same sentence as "specifically". Worth correcting while you amend for the patch-header rework.
Nothing here looks like it blocks a merge. The change itself checks out: PKG_RELEASE goes 2 → 3, which is what a new patch requires; USEAGENTLIBS is already an established variable in apps/Makefile.in (the snmppcap link rule in the hunk context uses it), so the added reference resolves; and the extra agent libraries are already shipped by libnetsnmp-nossl/libnetsnmp-ssl (libnetsnmp{,agent,helpers,mibs}.so.*), which snmptrapd-* depends on, so libnetsnmptrapd.so gains no unsatisfied runtime dependency. All twelve Feeds Package Test Build targets are green, which also confirms the patch applies without fuzz.
Two optional nits inline on the new patch file.
Generated by Claude Code
1d1b34a to
359dca5
Compare
The new version of the compiler imposes stricter requirements — specifically, it disallows linking against undefined functions. Consequently, the build fails when using the new version. A patch from Debian repository has been added to fix this issue. Discussion on main repository: net-snmp/net-snmp#434 Signed-off-by: Ivan Pavlov <AuthorReflex@gmail.com>
359dca5 to
f5a6b5a
Compare
openwrt-ai
left a comment
There was a problem hiding this comment.
Reviewed 1 new commit; no new issues found.
The force-push addresses both nits from the previous round: the patch is renamed to 140-debian-makefile_trap_needs_agent.patch, which now matches the 1x0-debian-* numbering its siblings use (100-debian-statistics, 110-debian-makefiles, 120-debian-searchdirs, 130-debian-extramibs), and the libnetsnmpaget → libnetsnmpagent typo plus the trailing whitespace in the DEP-3 header are fixed. The upstream issue link was added to the patch header, and especifically → specifically is corrected in the commit message, which otherwise still matches the diff (patch added, PKG_RELEASE 2 → 3).
The functional hunk is unchanged from what I reviewed at 5069eaa, and all ten Feeds Package Test Build targets are green on this head.
Generated by Claude Code
📦 Package Details
Maintainer: @stintel
Description:
The new version of the compiler imposes stricter requirements — specifically, it disallows linking against undefined functions. Consequently, the build fails when using the new version. A patch from Debian repository has been added
to fix this issue.
Discussion on main repository: net-snmp/net-snmp#434
🧪 Run Testing Details
✅ Formalities
If your PR contains a patch:
git am(e.g., subject line, commit description, etc.)
We must try to upstream patches to reduce maintenance burden.