Skip to content

[chores] Add width for select2 container - #747

Open
dee077 wants to merge 1 commit into
masterfrom
fix/add-width-select2-container
Open

[chores] Add width for select2 container#747
dee077 wants to merge 1 commit into
masterfrom
fix/add-width-select2-container

Conversation

@dee077

@dee077 dee077 commented Aug 31, 2026

Copy link
Copy Markdown
Member

Checklist

Description of Changes

  • Add width 320px to the select2 container so that long names won't affect the container width.
  • Tested on openwisp-controller with this change to verify it is correctly targeted.

Screenshot

image

@dee077 dee077 self-assigned this Aug 31, 2026
@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown

Review Change Stack

Important

Review skipped

No new commits to review since the last review.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Team

Run ID: fff0b60a-ba15-4337-a2ab-beadd7b3066d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Team

Run ID: b7c3a92b-850c-47af-89ef-500d44eb93a9

📥 Commits

Reviewing files that changed from the base of the PR and between 534478f and 9a06ce2.

📒 Files selected for processing (1)
  • openwisp_utils/admin_theme/static/admin/css/openwisp.css

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (14)
  • GitHub Check: Python==3.13 | django~=5.1.0
  • GitHub Check: Python==3.12 | django~=5.2.0
  • GitHub Check: Python==3.12 | django~=4.2.0
  • GitHub Check: Python==3.11 | django~=5.2.0
  • GitHub Check: Python==3.10 | django~=5.0.0
  • GitHub Check: Python==3.12 | django~=5.1.0
  • GitHub Check: Python==3.12 | django~=5.0.0
  • GitHub Check: Python==3.10 | django~=5.2.0
  • GitHub Check: Python==3.11 | django~=4.2.0
  • GitHub Check: Python==3.13 | django~=5.2.0
  • GitHub Check: Python==3.11 | django~=5.1.0
  • GitHub Check: Python==3.10 | django~=5.1.0
  • GitHub Check: Python==3.10 | django~=4.2.0
  • GitHub Check: Python==3.11 | django~=5.0.0
🧰 Additional context used
📓 Path-based instructions (1)
- Flag potential security vulnerabilities

⚙️ CodeRabbit configuration file

Files:

  • openwisp_utils/admin_theme/static/admin/css/openwisp.css
🔇 Additional comments (1)
openwisp_utils/admin_theme/static/admin/css/openwisp.css (1)

487-489: LGTM!


📝 Walkthrough

Walkthrough

The admin theme now limits Select2 containers within form rows under #main to a maximum width of 320px.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 9a06c

This change constrains the select2 container width to 320px to prevent long names from expanding the layout. No actionable merge-blocking risk remains beyond normal checks and review.


Caution

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

  • Ignore

❌ Failed checks (1 error)

Check name Status Explanation Resolution
Ui Changes, Regression Test, Docs ❌ Error The pull request changes the end-user admin UI: commit 9a06ce2 adds #main .form-row .select2-container { max-width: 320px; } to openwisp.css, which base_site.html loads. The description contai… Update the pull request description with screenshots of the UI before and after this change, or add a screen recording that clearly shows both states.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title uses the required [chores] prefix and clearly describes the Select2 container width change.
Description check ✅ Passed The description explains the CSS change, records manual testing, and includes a relevant screenshot. The issue reference section is missing, and the test and documentation checklist items are unchecke…
Full details: Ui Changes, Regression Test, Docs

Explanation

The pull request changes the end-user admin UI: commit 9a06ce2 adds #main .form-row .select2-container { max-width: 320px; } to openwisp.css, which base_site.html loads. The description contains one Screenshot image and does not include a before-and-after pair or a screen recording. The CSS adjustment is a trivial fix, so the regression-test exemption applies. No new feature or documented-feature content is introduced.

Full details: Description check

Explanation

The description explains the CSS change, records manual testing, and includes a relevant screenshot. The issue reference section is missing, and the test and documentation checklist items are unchecked, but the description is otherwise mostly complete.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/add-width-select2-container

Comment @coderabbitai help to get the list of available commands.

@openwisp-companion

Copy link
Copy Markdown

@coderabbitai review

@kilo-code-bot

kilo-code-bot Bot commented Aug 31, 2026

Copy link
Copy Markdown

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (1 file)
  • openwisp_utils/admin_theme/static/admin/css/openwisp.css
Previous Review Summary (commit 9a06ce2)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit 9a06ce2)

Status: No Issues Found | Recommendation: Merge

Files Reviewed (1 file)
  • openwisp_utils/admin_theme/static/admin/css/openwisp.css

Reviewed by balanced · Input: 36.1K · Output: 4.4K · Cached: 186.6K

@nemesifier

Copy link
Copy Markdown
Member

@coderabbitai did you review already?

@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown

@nemesifier Not yet. I am starting the review now.

⚠️ Action not completed

Already reviewed the last commit. Use @coderabbitai full review to rerun a review of the entire changeset.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@dee077
dee077 force-pushed the fix/add-width-select2-container branch from 9a06ce2 to ea06d4d Compare August 31, 2026 22:24
@coveralls

coveralls commented Aug 31, 2026

Copy link
Copy Markdown

Coverage Status

coverage: 97.635%. remained the same — fix/add-width-select2-container into master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

3 participants