[fix] Fix remote configuration getting stored if backup not available #153 - #154
Merged
Conversation
devkapilbansal
changed the title
devkapilbansal
force-pushed
the
issues/153-fix-configuration
branch
from
November 24, 2021 20:57
ecf7f10 to
668de1d
Compare
devkapilbansal
changed the title
devkapilbansal
force-pushed
the
issues/153-fix-configuration
branch
2 times, most recently
from
November 24, 2021 21:35
9fcce90 to
10f0740
Compare
devkapilbansal
marked this pull request as ready for review
November 24, 2021 21:36
okraits
reviewed
Nov 25, 2021
devkapilbansal
commented
Nov 29, 2021
devkapilbansal
force-pushed
the
issues/153-fix-configuration
branch
2 times, most recently
from
November 29, 2021 22:30
194a380 to
dec1ed0
Compare
devkapilbansal
changed the title
okraits
reviewed
Dec 2, 2021
devkapilbansal
force-pushed
the
issues/153-fix-configuration
branch
from
December 2, 2021 15:37
0d15300 to
fe2bc14
Compare
devkapilbansal
force-pushed
the
issues/153-fix-configuration
branch
from
December 3, 2021 22:38
fe2bc14 to
9f02107
Compare
Member
Author
|
I just rebased the branch |
nemesifier
approved these changes
Dec 9, 2021
nemesifier
left a comment
nemesifier
left a comment
Member
There was a problem hiding this comment.
@okraits @devkapilbansal I did some testing to verify the bug that I was having is not there anymore.
Please @okraits can you do a manual test of your original use case to ensure it's still working good for you (the backup of the original conf)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Store only when configuration is not in remote
Close #153