[Protopipe] EISW-225277 Add boolean type - #37422
Open
svigh wants to merge 5 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for a BOOL pseudo-precision in the Intel NPU protopipe tool, ensuring boolean tensors are treated as boolean at the OpenVINO precision level while still using CV_8U as the physical cv::Mat storage type (and generating valid 0/1 random input data by default).
Changes:
- Introduces
utils::kBooleanDepthandutils::toPhysicalDepth()to distinguish logical BOOL from physical CV_8U storage. - Extends precision parsing and OpenVINO precision conversion to handle
BOOL/ov::element::boolean. - Refactors initializer resolution into
resolveInitializers()with BOOL-aware defaults and updates docs/version accordingly.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/plugins/intel_npu/tools/protopipe/version.hpp.in | Bumps protopipe app version to v1.2.5. |
| src/plugins/intel_npu/tools/protopipe/src/utils/utils.hpp | Adds BOOL pseudo-depth marker and toPhysicalDepth() declaration. |
| src/plugins/intel_npu/tools/protopipe/src/utils/utils.cpp | Ensures cv::Mat::create() uses physical depth (CV_8U for BOOL). |
| src/plugins/intel_npu/tools/protopipe/src/utils/data_providers.hpp | Adds <string> include needed for generator stringification API. |
| src/plugins/intel_npu/tools/protopipe/src/utils/data_providers.cpp | Ensures RandomProvider::desc() reports physical depth for G-API metadata. |
| src/plugins/intel_npu/tools/protopipe/src/simulation/simulation.cpp | Maps configured output precision to physical depth for network compilation. |
| src/plugins/intel_npu/tools/protopipe/src/simulation/reference_mode.cpp | Switches to centralized initializer resolution (resolveInitializers). |
| src/plugins/intel_npu/tools/protopipe/src/simulation/performance_mode.cpp | Switches to centralized initializer resolution (resolveInitializers). |
| src/plugins/intel_npu/tools/protopipe/src/simulation/ov_layers_reader.cpp | Adds OV boolean precision mapping to/from protopipe precision representation. |
| src/plugins/intel_npu/tools/protopipe/src/simulation/layers_data.hpp | Declares resolveInitializers() with precision-aware fallback behavior. |
| src/plugins/intel_npu/tools/protopipe/src/simulation/layers_data.cpp | Implements resolveInitializers() and BOOL default generator (0/1 values). |
| src/plugins/intel_npu/tools/protopipe/src/simulation/accuracy_mode.cpp | Switches to centralized initializer resolution (resolveInitializers). |
| src/plugins/intel_npu/tools/protopipe/src/parser/config.cpp | Adds parsing support for BOOL precision in config. |
| src/plugins/intel_npu/tools/protopipe/README.md | Documents BOOL precision and clarifies default random initialization for BOOL inputs. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details:
Tickets:
AI Assistance: