Skip to content

[Transformations] Coverity fixes - #37404

Merged
mryzhov merged 5 commits into
openvinotoolkit:masterfrom
mryzhov:coverity_fixes
Aug 14, 2026
Merged

[Transformations] Coverity fixes#37404
mryzhov merged 5 commits into
openvinotoolkit:masterfrom
mryzhov:coverity_fixes

Conversation

@mryzhov

@mryzhov mryzhov commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Details:

  • Added a null check for variadic_split in GLUFusion::GLUFusion() to prevent dereferencing a null pointer if the pattern match fails.
  • Improved regex handling in make_unique_tensor_name by returning the original name if the regex does not match, preventing out-of-bounds access to regex match groups.
  • Changed the type of data to const auto& in GLUFusion::GLUFusion() for consistency and to avoid unnecessary copies.
  • Changed the type of resolve_node_name to const auto& in ResolveNameCollisions::run_on_model for consistency and to avoid unnecessary copies.

Tickets:

AI Assistance:

  • AI assistance used: no / yes
  • If yes, summarize how AI was used and what human validation was performed (build/tests/manual checks).

@mryzhov
mryzhov requested a review from a team as a code owner August 12, 2026 15:15
@github-actions github-actions Bot added the category: transformations OpenVINO Runtime library - Transformations label Aug 12, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Coverity-driven safety checks and avoids unnecessary copies in transformation passes.

Changes:

  • Guards failed VariadicSplit casts in GLU fusion.
  • Handles failed tensor-name regex matching.
  • Uses references for matched data and name resolvers.

Risk: The regex fallback preserves a colliding name instead of making it unique; a regression test is also needed.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
resolve_names_collisions.cpp Updates regex handling and resolver ownership.
glu_fusion.cpp Adds null protection and avoids a matched-value copy.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/common/transformations/src/transformations/resolve_names_collisions.cpp Outdated
@mryzhov
mryzhov requested a review from evkotov August 13, 2026 13:37

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

@mryzhov
mryzhov requested a balanced review from Copilot August 14, 2026 14:46
@mryzhov
mryzhov added this pull request to the merge queue Aug 14, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Merged via the queue into openvinotoolkit:master with commit 1872889 Aug 14, 2026
214 checks passed
@mryzhov
mryzhov deleted the coverity_fixes branch August 14, 2026 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: transformations OpenVINO Runtime library - Transformations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants