[Transformations] Coverity fixes - #37404
Merged
Merged
Conversation
CuriousPanCake
approved these changes
Aug 12, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Coverity-driven safety checks and avoids unnecessary copies in transformation passes.
Changes:
- Guards failed
VariadicSplitcasts in GLU fusion. - Handles failed tensor-name regex matching.
- Uses references for matched data and name resolvers.
Risk: The regex fallback preserves a colliding name instead of making it unique; a regression test is also needed.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
resolve_names_collisions.cpp |
Updates regex handling and resolver ownership. |
glu_fusion.cpp |
Adds null protection and avoids a matched-value copy. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
evkotov
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details:
variadic_splitinGLUFusion::GLUFusion()to prevent dereferencing a null pointer if the pattern match fails.make_unique_tensor_nameby returning the original name if the regex does not match, preventing out-of-bounds access to regex match groups.datatoconst auto&inGLUFusion::GLUFusion()for consistency and to avoid unnecessary copies.resolve_node_nametoconst auto&inResolveNameCollisions::run_on_modelfor consistency and to avoid unnecessary copies.Tickets:
AI Assistance: