[CPU]fix_coverity_scan_issues - #37338
Open
chenhu-wang wants to merge 1 commit into
Open
Conversation
chenhu-wang
force-pushed
the
chenhu/coverity_issues_fix
branch
from
August 10, 2026 11:45
8fc03ba to
241f458
Compare
Contributor
|
@nshchego , could you please review? |
chenhu-wang
force-pushed
the
chenhu/coverity_issues_fix
branch
5 times, most recently
from
August 11, 2026 07:55
b51bfca to
540281f
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
This PR addresses Coverity scan findings in the Intel CPU plugin by hardening edge cases (division-by-zero and invalid shapes) and improving exception-safety / memory handling in a few low-level components.
Changes:
- Add guards to prevent divide-by-zero in softmax and sparse-rate calculations.
- Add runtime validation for interpolation coordinate transform inputs.
- Adjust scratch buffer / memory construction and add exception handling in destructors.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| src/plugins/intel_cpu/src/nodes/scaled_attn.cpp | Avoid divide-by-zero when normalizing softmax output. |
| src/plugins/intel_cpu/src/nodes/llm_mlp.cpp | Change how scratch buffer pointer is shared between ops. |
| src/plugins/intel_cpu/src/nodes/kernels/x64/registers_pool.hpp | Add try/catch in destructors / move assignment and include iostream-based logging. |
| src/plugins/intel_cpu/src/nodes/kernels/scaled_attn/softmax_kernel.hpp | Avoid divide-by-zero when computing scalar for softmax. |
| src/plugins/intel_cpu/src/nodes/fullyconnected.cpp | Avoid divide-by-zero when computing sparse rate. |
| src/plugins/intel_cpu/src/nodes/executors/interpolate.cpp | Throw on invalid inShape == 0 in coordinate transform. |
| src/plugins/intel_cpu/src/nodes/executors/dnnl/dnnl_gathermatmul_executor.cpp | Construct Memory using MemoryBlock for tmp input. |
| src/plugins/intel_cpu/src/emitters/snippets/x64/utils.cpp | Add try/catch in destructor and iostream-based logging. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
chenhu-wang
force-pushed
the
chenhu/coverity_issues_fix
branch
from
August 12, 2026 01:33
540281f to
445ce46
Compare
chenhu-wang
force-pushed
the
chenhu/coverity_issues_fix
branch
from
August 12, 2026 08:45
445ce46 to
14ae35a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details:
Tickets:
AI Assistance: