[GPU][CLANG-TIDY] Enable readability-braces-around-statements - #37208
Open
allnes wants to merge 1 commit into
Open
[GPU][CLANG-TIDY] Enable readability-braces-around-statements#37208allnes wants to merge 1 commit into
allnes wants to merge 1 commit into
Conversation
allnes
marked this pull request as ready for review
August 3, 2026 15:50
allnes
force-pushed
the
an/gpu-clang-tidy-braces
branch
2 times, most recently
from
August 3, 2026 16:23
c7d8b14 to
dd33c96
Compare
allnes
marked this pull request as draft
August 3, 2026 16:23
allnes
force-pushed
the
an/gpu-clang-tidy-braces
branch
from
August 3, 2026 17:05
dd33c96 to
0fc17e4
Compare
allnes
marked this pull request as ready for review
August 3, 2026 17:28
allnes
force-pushed
the
an/gpu-clang-tidy-braces
branch
from
August 3, 2026 17:42
0fc17e4 to
e0dc69f
Compare
allnes
marked this pull request as draft
August 3, 2026 17:43
allnes
marked this pull request as ready for review
August 3, 2026 17:46
p-durandin
approved these changes
Aug 4, 2026
p-durandin
left a comment
p-durandin
left a comment
Contributor
There was a problem hiding this comment.
Approved as pattern modifications
p-durandin
enabled auto-merge
August 4, 2026 06:24
allnes
disabled auto-merge
August 4, 2026 07:59
allnes
force-pushed
the
an/gpu-clang-tidy-braces
branch
3 times, most recently
from
August 6, 2026 15:29
cd2f760 to
0dbaf8c
Compare
maxnick
approved these changes
Aug 7, 2026
Enables readability-braces-around-statements (ShortStatementLines=1) for the Intel GPU plugin and adds braces to single-statement control-flow bodies. Macro-body sites (DO_NOT_USE_THIS_KERNEL) that clang-tidy cannot rewrite were braced by hand. Next check in the incremental clang-tidy rollout for the plugin.
allnes
force-pushed
the
an/gpu-clang-tidy-braces
branch
from
August 7, 2026 16:32
0dbaf8c to
180bea0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables the
readability-braces-around-statementscheck (withShortStatementLinesset to 1, matching the CPU plugin) for the Intel GPU plugin and wraps single-statementif/else/for/while/dobodies in braces. Most changes are the mechanical brace insertion; a number of guard clauses whose body is theDO_NOT_USE_THIS_KERNEL(...)macro are wrapped by hand since the check does not offer an automatic fix for macro bodies. The copyright header of a few touched files is corrected in passing so the copyright CI check stays green. Next check in the incremental clang-tidy rollout for the plugin.