downgrade InvalidReport from logging error to debug - #1864
Merged
Conversation
Signed-off-by: greenwyrt <117969582+greenwyrt@users.noreply.github.com>
greenwyrt
marked this pull request as ready for review
August 11, 2026 20:49
mkrnr
approved these changes
Aug 11, 2026
mkrnr
left a comment
mkrnr
left a comment
Contributor
There was a problem hiding this comment.
Thanks! I'd say we don't need a news entry for this fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
I have a keyboard that switches between PloverHID and mouse keys.
On Windows, I can use PloverHID and switch with the mouse keys with no errors.
On Linux, I get the invalid report error if I try to use mouse keys.
In Linux, HID devices share the same path even though they may have multiple usage and usage pages (unlike Windows which seems to generate unique paths). Plover will attempt to read non-PloverHID data packets (mousekey events in my case), and raise InvalidReport errors, generating multiple system notifications.
The change in log level will stop the notifications, but debug output will still show the exception.
Pull Request Checklist