Fix type of SUPPORTED_ROLES in dictionaries widget - #1854
Merged
Conversation
toyboot4e
marked this pull request as draft
July 12, 2026 06:06
toyboot4e
marked this pull request as ready for review
July 12, 2026 06:12
toyboot4e
marked this pull request as draft
July 12, 2026 06:13
toyboot4e
marked this pull request as ready for review
July 12, 2026 06:32
mkrnr
approved these changes
Jul 12, 2026
mkrnr
left a comment
mkrnr
left a comment
Contributor
There was a problem hiding this comment.
Thanks a lot for this fix! And that solves the open question in that test which is nice 🙂
mkrnr
changed the title
SUPPORTED_ROLESSUPPORTED_ROLES in dictionaries widget
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Send a list, not a set, as in the official PySide repository:
https://github.com/qtproject/pyside-pyside-setup/blob/6389b54051d11154bb26874af1351dfa82c9d66e/examples/widgets/tutorials/modelview/3_changingmodel.py#L44
_pythonToCppCopy: Cannot copy-convert 0x7ff8019427a0 (set) to C++.#1853.Tests
I confirmed that the startup error log was suppressed after this change.
Pull Request Checklist