feat(adr0034): Build per-instance assignment backends - #1218
Merged
Conversation
The OpenFGA driver read the global [openfga] section on every backend call, so two instances always hit the same store. Give it a config_override for a pinned [assignment.backends.<name>] block; the global instance keeps reading the live section. Add NamedAssignmentBackendRegistration plus build_global_assignment_backend and build_named_assignment_backend so a reload can rebuild instances without a PluginManager (inventory::iter lives in core). Expose PluginManagerApi::assignment_backends() to seed the dispatch bundle. Signed-off-by: Artem Goncharov <artem.goncharov@gmail.com>
gtema
enabled auto-merge
September 7, 2026 16:16
|
🦢 Load Test Results Goose Attack ReportPlan Overview
Request Metrics
Response Time Metrics
Status Code Metrics
Transaction Metrics
Scenario Metrics
Error Metrics
|
|
🧪 Tempest Identity Compatibility Results (advisory, non-blocking) rust Failed test IDs |
|
Bencher Report| Project | keystone |
| Branch | claude/per-domain-assignments-provider-k0tp5e |
| Testbed | ubuntu-latest |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result nanoseconds (ns) (Result Δ%) | Upper Boundary nanoseconds (ns) (Limit %) |
|---|---|---|---|
| Command_Serde/apply/remove | 📈 view plot 🚷 view threshold | 131,630.00 ns(-48.23%)Baseline: 254,269.16 ns | 1,303,191.60 ns (10.10%) |
| Command_Serde/apply/set | 📈 view plot 🚷 view threshold | 140,660.00 ns(-65.40%)Baseline: 406,528.52 ns | 3,194,083.20 ns (4.40%) |
| Command_Serde/pack/delete | 📈 view plot 🚷 view threshold | 120.63 ns(+1.73%)Baseline: 118.58 ns | 155.44 ns (77.61%) |
| Command_Serde/pack/delete_index | 📈 view plot 🚷 view threshold | 108.30 ns(+2.35%)Baseline: 105.81 ns | 138.40 ns (78.25%) |
| Command_Serde/pack/set | 📈 view plot 🚷 view threshold | 199.06 ns(+3.95%)Baseline: 191.50 ns | 245.64 ns (81.04%) |
| Command_Serde/pack/set_index | 📈 view plot 🚷 view threshold | 110.62 ns(+4.58%)Baseline: 105.78 ns | 139.01 ns (79.58%) |
| Command_Serde/unpack/delete | 📈 view plot 🚷 view threshold | 197.41 ns(+4.92%)Baseline: 188.16 ns | 268.56 ns (73.51%) |
| Command_Serde/unpack/delete_index | 📈 view plot 🚷 view threshold | 156.53 ns(+0.00%)Baseline: 156.52 ns | 217.01 ns (72.13%) |
| Command_Serde/unpack/set | 📈 view plot 🚷 view threshold | 297.04 ns(+12.49%)Baseline: 264.05 ns | 357.91 ns (82.99%) |
| Command_Serde/unpack/set_index | 📈 view plot 🚷 view threshold | 157.82 ns(+2.48%)Baseline: 154.01 ns | 211.38 ns (74.66%) |
| Payload_encryption/pack/remove_cmd | 📈 view plot 🚷 view threshold | 115.94 ns(+2.72%)Baseline: 112.87 ns | 149.41 ns (77.60%) |
| Payload_encryption/pack/set_cmd | 📈 view plot 🚷 view threshold | 225.39 ns(+13.25%)Baseline: 199.02 ns | 261.20 ns (86.29%) |
| Payload_encryption/unpack/remove_cmd | 📈 view plot 🚷 view threshold | 208.94 ns(+6.11%)Baseline: 196.90 ns | 282.69 ns (73.91%) |
| Payload_encryption/unpack/set_cmd | 📈 view plot 🚷 view threshold | 300.72 ns(+9.85%)Baseline: 273.76 ns | 375.56 ns (80.07%) |
| Raft_1Node_Latency/prefix/1node | 📈 view plot 🚷 view threshold | 2,628,700.00 ns(-13.84%)Baseline: 3,051,064.67 ns | 7,824,512.96 ns (33.60%) |
| Raft_1Node_Latency/read/1node | 📈 view plot 🚷 view threshold | 45,299.00 ns(+20.89%)Baseline: 37,471.11 ns | 51,467.76 ns (88.01%) |
| Raft_1Node_Latency/remove/1node | 📈 view plot 🚷 view threshold | 375,850.00 ns(-67.91%)Baseline: 1,171,094.84 ns | 11,496,337.95 ns (3.27%) |
| Raft_1Node_Latency/write/1node | 📈 view plot 🚷 view threshold | 405,430.00 ns(-58.53%)Baseline: 977,644.84 ns | 7,556,069.30 ns (5.37%) |
| build_snapshot/default | 📈 view plot 🚷 view threshold | 116,920.00 ns(-4.77%)Baseline: 122,781.77 ns | 268,592.95 ns (43.53%) |
| fernet token/project | 📈 view plot 🚷 view threshold | 1,507.60 ns(+5.59%)Baseline: 1,427.83 ns | 1,796.26 ns (83.93%) |
| get_data_keyspace | 📈 view plot 🚷 view threshold | 0.31 ns(-1.41%)Baseline: 0.32 ns | 0.39 ns (80.59%) |
| get_db | 📈 view plot 🚷 view threshold | 0.31 ns(-1.73%)Baseline: 0.32 ns | 0.39 ns (80.46%) |
| get_fernet_token_timestamp/project | 📈 view plot 🚷 view threshold | 155.75 ns(+10.90%)Baseline: 140.44 ns | 180.02 ns (86.52%) |
| get_keyspace | 📈 view plot 🚷 view threshold | 4.46 ns(-22.87%)Baseline: 5.78 ns | 13.37 ns (33.34%) |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OpenFGA driver read the global [openfga] section on every backend
call, so two instances always hit the same store. Give it a
config_override for a pinned [assignment.backends.] block; the
global instance keeps reading the live section.
Add NamedAssignmentBackendRegistration plus
build_global_assignment_backend and build_named_assignment_backend so a
reload can rebuild instances without a PluginManager (inventory::iter
lives in core). Expose PluginManagerApi::assignment_backends() to seed
the dispatch bundle.
Signed-off-by: Artem Goncharov artem.goncharov@gmail.com