feat(adr0034): Add per-domain driver config surface - #1216
Merged
Conversation
First of the stacked ADR 0034 PRs: parse-only, no dispatch wired yet. - `[domain_config]` section with `Option<bool>` from_files/from_database so an unset key inherits the deprecated `[identity]` switch - `[assignment]` gains domain_specific_drivers_enabled, plus `[assignment.backends.<name>]` driver blocks and an `[assignment.domains]` id->block map; INI merge of the leaf and nested sections is covered by test - `assignment` domain-config group (whitelist: `driver` only, no sensitive options) with resolve_assignment_driver_name and a validate_values arm rejecting a non-scalar driver - fs and sql domain-config driver tests move their "unknown group" fixture off `assignment` (now supported) onto `quota` Signed-off-by: Artem Goncharov <artem.goncharov@gmail.com>
gtema
enabled auto-merge
September 7, 2026 13:10
|
🧪 Tempest Identity Compatibility Results (advisory, non-blocking) rust Failed test IDs |
|
🦢 Load Test Results Goose Attack ReportPlan Overview
Request Metrics
Response Time Metrics
Status Code Metrics
Transaction Metrics
Scenario Metrics
Error Metrics
|
|
Bencher Report| Project | keystone |
| Branch | claude/per-domain-assignments-provider-k0tp5e |
| Testbed | ubuntu-latest |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result nanoseconds (ns) (Result Δ%) | Upper Boundary nanoseconds (ns) (Limit %) |
|---|---|---|---|
| Command_Serde/apply/remove | 📈 view plot 🚷 view threshold | 134,840.00 ns(-48.98%)Baseline: 264,301.97 ns | 1,326,263.65 ns (10.17%) |
| Command_Serde/apply/set | 📈 view plot 🚷 view threshold | 143,670.00 ns(-66.06%)Baseline: 423,276.80 ns | 3,222,667.47 ns (4.46%) |
| Command_Serde/pack/delete | 📈 view plot 🚷 view threshold | 120.72 ns(+2.03%)Baseline: 118.32 ns | 155.47 ns (77.65%) |
| Command_Serde/pack/delete_index | 📈 view plot 🚷 view threshold | 109.36 ns(+3.62%)Baseline: 105.54 ns | 138.42 ns (79.00%) |
| Command_Serde/pack/set | 📈 view plot 🚷 view threshold | 203.30 ns(+6.43%)Baseline: 191.01 ns | 245.37 ns (82.85%) |
| Command_Serde/pack/set_index | 📈 view plot 🚷 view threshold | 108.37 ns(+2.71%)Baseline: 105.51 ns | 139.04 ns (77.94%) |
| Command_Serde/unpack/delete | 📈 view plot 🚷 view threshold | 199.39 ns(+6.60%)Baseline: 187.05 ns | 268.87 ns (74.16%) |
| Command_Serde/unpack/delete_index | 📈 view plot 🚷 view threshold | 160.43 ns(+2.89%)Baseline: 155.92 ns | 217.52 ns (73.76%) |
| Command_Serde/unpack/set | 📈 view plot 🚷 view threshold | 303.09 ns(+15.50%)Baseline: 262.42 ns | 356.17 ns (85.10%) |
| Command_Serde/unpack/set_index | 📈 view plot 🚷 view threshold | 162.56 ns(+6.01%)Baseline: 153.34 ns | 211.68 ns (76.80%) |
| Payload_encryption/pack/remove_cmd | 📈 view plot 🚷 view threshold | 123.82 ns(+9.75%)Baseline: 112.82 ns | 149.67 ns (82.73%) |
| Payload_encryption/pack/set_cmd | 📈 view plot 🚷 view threshold | 202.80 ns(+2.36%)Baseline: 198.12 ns | 260.30 ns (77.91%) |
| Payload_encryption/unpack/remove_cmd | 📈 view plot 🚷 view threshold | 203.43 ns(+3.83%)Baseline: 195.93 ns | 283.69 ns (71.71%) |
| Payload_encryption/unpack/set_cmd | 📈 view plot 🚷 view threshold | 300.77 ns(+10.44%)Baseline: 272.34 ns | 375.28 ns (80.15%) |
| Raft_1Node_Latency/prefix/1node | 📈 view plot 🚷 view threshold | 2,700,100.00 ns(-10.57%)Baseline: 3,019,131.70 ns | 7,853,027.86 ns (34.38%) |
| Raft_1Node_Latency/read/1node | 📈 view plot 🚷 view threshold | 44,087.00 ns(+17.93%)Baseline: 37,383.44 ns | 51,473.46 ns (85.65%) |
| Raft_1Node_Latency/remove/1node | 📈 view plot 🚷 view threshold | 390,900.00 ns(-68.43%)Baseline: 1,238,104.69 ns | 11,618,758.85 ns (3.36%) |
| Raft_1Node_Latency/write/1node | 📈 view plot 🚷 view threshold | 406,740.00 ns(-59.70%)Baseline: 1,009,288.91 ns | 7,604,647.77 ns (5.35%) |
| build_snapshot/default | 📈 view plot 🚷 view threshold | 111,940.00 ns(-10.70%)Baseline: 125,357.83 ns | 277,027.19 ns (40.41%) |
| fernet token/project | 📈 view plot 🚷 view threshold | 1,465.30 ns(+2.77%)Baseline: 1,425.77 ns | 1,795.20 ns (81.62%) |
| get_data_keyspace | 📈 view plot 🚷 view threshold | 0.31 ns(-1.25%)Baseline: 0.32 ns | 0.39 ns (80.70%) |
| get_db | 📈 view plot 🚷 view threshold | 0.31 ns(-1.72%)Baseline: 0.32 ns | 0.39 ns (80.45%) |
| get_fernet_token_timestamp/project | 📈 view plot 🚷 view threshold | 153.03 ns(+9.15%)Baseline: 140.20 ns | 179.47 ns (85.27%) |
| get_keyspace | 📈 view plot 🚷 view threshold | 4.41 ns(-25.53%)Baseline: 5.92 ns | 13.81 ns (31.90%) |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of the stacked ADR 0034 PRs: parse-only, no dispatch wired yet.
[domain_config]section withOption<bool>from_files/from_databaseso an unset key inherits the deprecated
[identity]switch[assignment]gains domain_specific_drivers_enabled, plus[assignment.backends.<name>]driver blocks and an[assignment.domains]id->block map; INI merge of the leaf andnested sections is covered by test
assignmentdomain-config group (whitelist:driveronly, nosensitive options) with resolve_assignment_driver_name and a
validate_values arm rejecting a non-scalar driver
fixture off
assignment(now supported) ontoquotaSigned-off-by: Artem Goncharov artem.goncharov@gmail.com