OCPEDGE-3079: UnifiedClusterManagedDNSAndLB FeatureGate

[pmtk]

No description provided.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@pmtk: This pull request references OCPEDGE-3079 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.1.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Hello @pmtk! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 9e7c3592-b1f6-487a-88fc-5aa5c06de616

📥 Commits

Reviewing files that changed from the base of the PR and between d9e140c and 2cd735c.

📒 Files selected for processing (2)

• features.md
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-DevPreviewNoUpgrade.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.

---

📝 Walkthrough

Walkthrough

The change registers UnifiedClusterManagedDNSAndLB as an OCP-specific feature gate with Mutable Topology ownership. The registration enables it for SelfManaged clusters and specified no-upgrade configurations. The feature matrix marks it enabled for SelfManagedHA DevPreviewNoUpgrade and leaves other values unset. The 4.10 manifests list it as disabled except in the SelfManagedHA DevPreviewNoUpgrade manifest, where it is enabled.

Suggested reviewers: vr4manta

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 2cd73

The gate’s registration and listed 4.10 configuration agree, with no remaining actionable issue indicated for merge.

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	No pull request description was provided. The changeset is clear, but the description check cannot confirm that the author documented the change.	Add a brief description that explains the UnifiedClusterManagedDNSAndLB feature gate registration and its enabled or disabled configurations.

✅ Passed checks (14 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the main change: adding the UnifiedClusterManagedDNSAndLB feature gate. It is concise and specific.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The pull request changes one feature declaration, documentation, and feature-gate YAML manifests. It does not change test files or add Ginkgo test titles. Therefore, it introduces no unstable or overl…
Test Structure And Quality	✅ Passed	PASS: The pull request changes only feature-gate registration, documentation, and YAML manifests. It adds no Ginkgo tests, test setup, waits, or assertions, so none of the stated test-quality failure …
Microshift Test Compatibility	✅ Passed	The pull request changes only feature-gate documentation, Go feature-gate registration, and feature-gate YAML manifests. The authoritative diff adds no Ginkgo e2e tests or other test code. Therefore, …
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The pull request changes only feature metadata and feature-gate YAML manifests. The authoritative diff contains no new Ginkgo tests or test files, so the SNO multi-node test compatibility check does n…
Topology-Aware Scheduling Compatibility	✅ Passed	The PR adds only feature-gate registration, documentation, and feature-gate list entries. The diff adds no deployment, operator, controller, replica, affinity, topology spread, node selector, tolerati…
Ote Binary Stdout Contract	✅ Passed	PASS. The pull request changes one feature-gate initializer, documentation, and JSON-style feature-gate manifests. The new initializer only sets metadata, updates registration state, and may panic on …
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The pull request adds a feature-gate declaration, documentation, and feature-gate manifest entries only. The authoritative diff contains no new Ginkgo tests or other test code, so the IPv4 and externa…
No-Weak-Crypto	✅ Passed	The pull request adds only the UnifiedClusterManagedDNSAndLB feature-gate registration, documentation, and manifest entries. The diff contains no MD5, SHA1, DES, 3DES, RC4, Blowfish, ECB, custom cry…
Container-Privileges	✅ Passed	The authoritative diff contains only a feature-gate registration, documentation, and FeatureGate status entries. The added manifest entries are names under disabled or enabled feature-gate arrays, not…
No-Sensitive-Data-In-Logs	✅ Passed	PASS: The PR changes only feature-gate registration, documentation, and YAML manifests. The added lines contain no logging calls or sensitive data. The contactPerson value is repository metadata, no…

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

---

_{Comment @coderabbitai help to get the list of available commands.}

[eggfoobar]

We're missing DevPreviewNoUpgrade set here. Lets add that and we should be good :)

[pmtk]

Added

[eggfoobar]

/lgtm

[openshift-merge-bot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change
/test minor-e2e-upgrade-minor

[JoelSpeed]

DPNU only, this allows Patryk to move forward as discussed, once Egli's EP is open, please update the EP reference here
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eggfoobar, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[pmtk]

/retest

[pmtk]

/retest

[redhat-chai-bot]

/override-sticky ci/prow/e2e-aws-ovn-techpreview

Automated triage: This failure appears unrelated to the PR changes.

Job classification: Eligible long-running AWS OVN TechPreview e2e/integration job. The definition uses the openshift-e2e-aws workflow with IPI AWS provisioning and the openshift-e2e-test test phase; the run lasted 3h12m.
Revision check: run 2cd735cf05468210d28de312ec358f2149ba5233; current PR HEAD 2cd735cf05468210d28de312ec358f2149ba5233; match.
Execution status: Tests executed. The run completed cluster provisioning and executed 2,283 passing, 4 blocking failing, 2 informing failing, and 2,121 skipped e2e tests; the suite ran for 1h43m19s. The blocking failures were ResourceQuota terminating scopes, AWS NLB security groups, UserDefinedNetwork deletion, and CRI-O dev fuse.
Completed supporting jobs: ci/prow/e2e-aws-ovn, ci/prow/e2e-aws-ovn-hypershift, ci/prow/e2e-aws-ovn-hypershift-conformance, ci/prow/e2e-aws-serial-techpreview-1of2, ci/prow/e2e-aws-serial-techpreview-2of2, ci/prow/e2e-gcp, ci/prow/e2e-upgrade, and ci/prow/e2e-upgrade-out-of-change passed on this HEAD. Pending: ci/prow/e2e-azure and tide.
Fleet-wide failure rate: Job pass rate was 28.1% (9/32) over the last 14 days. Failing-test global/AWS pass rates: ResourceQuota 99.9%/99.8%; UserDefinedNetwork deletion 99.7%/100%; CRI-O dev fuse 98.9%/97.9%; AWS NLB security groups 34.1%/34.1%.
Open regressions: None found for the failing tests in the 5.1 Component Readiness view.
Linked bugs: No open linked bug was used to justify this override. Existing test associations were closed or verified; internal issue identifiers are omitted from this public PR comment.
Overlap assessment: The PR changes feature-gate registration, documentation, and payload feature-gate manifests for UnifiedClusterManagedDNSAndLB. It does not change ResourceQuota, UserDefinedNetwork, CRI-O, IngressController, router, or AWS load-balancer implementation. The failing NLB test uses a different feature gate; no direct or indirect overlap with the failing test surfaces was found.
Missing-coverage risk: Low. The job executed the full e2e suite, the PR's build/unit/integration/verification checks passed, multiple AWS e2e and TechPreview jobs passed on this HEAD, and the dominant NLB failure is a high-frequency pre-existing fleet failure rather than a new failure attributable to this PR.
Prior bot activity on this SHA: /test e2e-aws-ovn-techpreview was already triggered once on this SHA; two later generic /retest commands also occurred. No prior override was recorded.
Rationale: The run is on the live HEAD and executed tests. The job is chronically unhealthy outside this PR, the AWS NLB test fails in 65.9% of fleet runs, and the other blocking failures are isolated failures with no PR overlap. The failure is therefore classified as unrelated to this API-only feature-gate metadata change.

If you disagree with this assessment, rerun the current job with /test e2e-aws-ovn-techpreview.

---

AI-generated. Review for accuracy.

[openshift-ci]

@redhat-chai-bot: Overrode contexts on behalf of redhat-chai-bot: ci/prow/e2e-aws-ovn-techpreview

These overrides will persist across retests on the current HEAD SHA. Pushing a new commit will clear them. Use /override-cancel to remove them.

Details

In response to this:

/override-sticky ci/prow/e2e-aws-ovn-techpreview

Automated triage: This failure appears unrelated to the PR changes.

Job classification: Eligible long-running AWS OVN TechPreview e2e/integration job. The definition uses the openshift-e2e-aws workflow with IPI AWS provisioning and the openshift-e2e-test test phase; the run lasted 3h12m.
Revision check: run 2cd735cf05468210d28de312ec358f2149ba5233; current PR HEAD 2cd735cf05468210d28de312ec358f2149ba5233; match.
Execution status: Tests executed. The run completed cluster provisioning and executed 2,283 passing, 4 blocking failing, 2 informing failing, and 2,121 skipped e2e tests; the suite ran for 1h43m19s. The blocking failures were ResourceQuota terminating scopes, AWS NLB security groups, UserDefinedNetwork deletion, and CRI-O dev fuse.
Completed supporting jobs: ci/prow/e2e-aws-ovn, ci/prow/e2e-aws-ovn-hypershift, ci/prow/e2e-aws-ovn-hypershift-conformance, ci/prow/e2e-aws-serial-techpreview-1of2, ci/prow/e2e-aws-serial-techpreview-2of2, ci/prow/e2e-gcp, ci/prow/e2e-upgrade, and ci/prow/e2e-upgrade-out-of-change passed on this HEAD. Pending: ci/prow/e2e-azure and tide.
Fleet-wide failure rate: Job pass rate was 28.1% (9/32) over the last 14 days. Failing-test global/AWS pass rates: ResourceQuota 99.9%/99.8%; UserDefinedNetwork deletion 99.7%/100%; CRI-O dev fuse 98.9%/97.9%; AWS NLB security groups 34.1%/34.1%.
Open regressions: None found for the failing tests in the 5.1 Component Readiness view.
Linked bugs: No open linked bug was used to justify this override. Existing test associations were closed or verified; internal issue identifiers are omitted from this public PR comment.
Overlap assessment: The PR changes feature-gate registration, documentation, and payload feature-gate manifests for UnifiedClusterManagedDNSAndLB. It does not change ResourceQuota, UserDefinedNetwork, CRI-O, IngressController, router, or AWS load-balancer implementation. The failing NLB test uses a different feature gate; no direct or indirect overlap with the failing test surfaces was found.
Missing-coverage risk: Low. The job executed the full e2e suite, the PR's build/unit/integration/verification checks passed, multiple AWS e2e and TechPreview jobs passed on this HEAD, and the dominant NLB failure is a high-frequency pre-existing fleet failure rather than a new failure attributable to this PR.
Prior bot activity on this SHA: /test e2e-aws-ovn-techpreview was already triggered once on this SHA; two later generic /retest commands also occurred. No prior override was recorded.
Rationale: The run is on the live HEAD and executed tests. The job is chronically unhealthy outside this PR, the AWS NLB test fails in 65.9% of fleet runs, and the other blocking failures are isolated failures with no PR overlap. The failure is therefore classified as unrelated to this API-only feature-gate metadata change.

If you disagree with this assessment, rerun the current job with /test e2e-aws-ovn-techpreview.

---

AI-generated. Review for accuracy.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[pmtk]

/verified by ci

[openshift-ci-robot]

@pmtk: This PR has been marked as verified by ci.

Details

In response to this:

/verified by ci

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@pmtk: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.