Refactor verify-* CLI commands to share common utilities

[redhat-chai-bot]

Summary

Consolidates duplicated logic across the five verify-* elliott subcommands into a shared module (elliottlib/verify_common.py), reducing copy-paste and standardizing the result interface.

This is a purely mechanical refactoring — no behavioral changes.

What changed

New: elliott/elliottlib/verify_common.py

Shared utilities extracted from the 5 verify commands:

• get_assembly_advisory_ids(runtime, include_types, exclude_types) — replaces 3 near-identical get_advisory_ids() functions in verify_security_alerts, verify_kernel_tag, and verify_cdn_push
• VerifyResultBase — abstract base dataclass standardizing .passed / .failed / .error across all 5 commands (previously inconsistent: .ok, .passed, .complete)
• render_verify_result(result, output) — generic JSON/text renderer replacing 5 copies of render_result()
• verify_output_option — shared Click --output decorator
• handle_verify_result(result, output) — shared echo + SystemExit(1) tail

Updated: all 5 verify_*_cli.py files

• Replaced local get_advisory_ids() with shared get_assembly_advisory_ids()
• Replaced local result dataclasses with subclasses of VerifyResultBase
• Standardized success property to .passed everywhere
• Replaced local render_result() with render_verify_result() / handle_verify_result()
• Used shared verify_output_option decorator

Updated: all 5 test files

• Updated imports (render_result → render_verify_result)
• Updated property assertions (.ok → .passed, .complete → .passed)

New: elliott/tests/test_verify_common.py

14 tests covering the shared module.

Property rename mapping

Command	Before	After
verify-security-alerts	.ok	.passed
verify-kernel-tag	.passed	.passed (unchanged)
verify-cdn-push	.complete	.passed
verify-qe-qualifier	.passed	.passed (unchanged)
verify-metadata-url	.passed	.passed (unchanged)

Test results

• 179 tests passed (165 existing + 14 new)
• Lint (ruff check + format): clean

Stats

12 files changed, +547 / -363 lines

---

AI-generated. Review for accuracy.

@tomasdavidorg requested in Slack thread

[coderabbitai]

Warning

Review limit reached

@redhat-chai-bot, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 4 minutes

Limit details: You’ve used all 1 included review currently available under your plan.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Repository: openshift-eng/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: e2d7e3e6-7944-4ed8-8e16-708490f9f7b0

📥 Commits

Reviewing files that changed from the base of the PR and between 3ccde95 and 373dd6e.

📒 Files selected for processing (12)

• elliott/elliottlib/cli/verify_cdn_push_cli.py
• elliott/elliottlib/cli/verify_kernel_tag_cli.py
• elliott/elliottlib/cli/verify_metadata_url_cli.py
• elliott/elliottlib/cli/verify_qe_qualifier_cli.py
• elliott/elliottlib/cli/verify_security_alerts_cli.py
• elliott/elliottlib/verify_common.py
• elliott/tests/test_verify_cdn_push_cli.py
• elliott/tests/test_verify_common.py
• elliott/tests/test_verify_kernel_tag_cli.py
• elliott/tests/test_verify_metadata_url_cli.py
• elliott/tests/test_verify_qe_qualifier_cli.py
• elliott/tests/test_verify_security_alerts_cli.py

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

@redhat-chai-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/security	373dd6e	link	false	/test security

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[tomasdavidorg]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tomasdavidorg
Once this PR has been reviewed and has the lgtm label, please assign joepvd for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment