Repository navigation
Remove deploy check for dependabot - #2080
Conversation
As it is no longer needed, dependabot should be able to deploy a preview URL
Deploying opensafely-docs with
|
| Latest commit: |
1959da7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3ffda410.opensafely-docs.pages.dev |
| Branch Preview URL: | https://tomodwyer-dependabot-deploy.opensafely-docs.pages.dev |
| run: echo ${{ github.sha }} > site/version.html | ||
|
|
||
| - name: Publish | ||
| if: ${{ github.actor != 'dependabot[bot]' }} |
There was a problem hiding this comment.
question: Because this took me a few minutes to unravel, I'll document my understanding which is:
- Dependabot opens a PR.
- The PR triggers this workflow.
- A Dependabot-triggered workflow does not get secret access (unless those are stored as Dependabot secrets.
wrangler-actionwill fail because of not having the secrets.
For example, in a recent Dependabot PR, this workflow did run (due to the push trigger), and this specific "Publish" step was skipped. So I believe the "Publish" step would have failed if wasn't skipped.
None of this behaviour has changed.
So, we get to my question. The difference between team-manual where this was discussed, and this process works without the exemption here, is that: in team-manual, we've added these secrets as Dependabot secrets.
Are we intending to do that here? Otherwise, this workflow will fail for Dependabot.
There was a problem hiding this comment.
Yup that's all correct, and I am adding the secrets now to this repo (once I remembered where they were added)
There was a problem hiding this comment.
Thanks for confirming!
Closes #930.
As it is no longer needed, dependabot should be able to deploy a preview URL