You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Gentle bump on this — the @node-minify/core@8.0.6 chain it fixes is now a flagged security advisory for downstream consumers.
@opennextjs/aws@4.1.0 still pins @node-minify/core@^8.0.6, whose transitive glob@9 → minimatch@8 → brace-expansion@2.1.2 falls under GHSA-mh99-v99m-4gvg / CVE-2026-14257 (brace-expansion DoS; flat range <= 5.0.7, patched in 5.0.8). This PR's bump to @node-minify/core@^10.5.0 pulls minimatch@10, which is the only compatible way to reach a patched brace-expansion on that path.
The security impact — and why consumers can't safely work around it themselves — is written up in #1204: a naive brace-expansion override is a false green (npm audit reports 0 vulnerabilities while the build breaks with expand is not a function, since minimatch@8 imports the default export that 5.x dropped).
Would it be possible to get a review here? Happy to help test against a Next.js + @opennextjs/cloudflare build if that's useful. Thanks for maintaining OpenNext!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@node-minify/coreand@node-minify/terserfrom version^8.0.6to^10.5.0inpackage.jsonminifyandterserto use named imports, as required by the new version of@node-minify.minimize-js.tsto skip minification for empty files as terser no longer handles them gracefully.This should reduce the security warnings shown in the console.