Skip to content

8389921: Changes in hlsl files do not dirty build sources - #2252

Open
nlisker wants to merge 4 commits into
openjdk:masterfrom
nlisker:8389921_Changes_in_hlsl_files_do_not_dirty_build_sources
Open

8389921: Changes in hlsl files do not dirty build sources#2252
nlisker wants to merge 4 commits into
openjdk:masterfrom
nlisker:8389921_Changes_in_hlsl_files_do_not_dirty_build_sources

Conversation

@nlisker

@nlisker nlisker commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator
  • Adds the missing .h files as inputs.
  • Names the input properties for -i debug info.
  • Removes a redundant nested output dir.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8389921: Changes in hlsl files do not dirty build sources (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/2252/head:pull/2252
$ git checkout pull/2252

Update a local copy of the PR:
$ git checkout pull/2252
$ git pull https://git.openjdk.org/jfx.git pull/2252/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2252

View PR using the GUI difftool:
$ git pr show -t 2252

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/2252.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Aug 7, 2026

Copy link
Copy Markdown

👋 Welcome back nlisker! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Aug 7, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@nlisker
nlisker marked this pull request as ready for review August 14, 2026 16:56
@openjdk openjdk Bot added the rfr Ready for review label Aug 14, 2026
@nlisker

nlisker commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator Author

@arapte and/or @lukostyra. please review.

@openjdk

openjdk Bot commented Aug 14, 2026

Copy link
Copy Markdown

The total number of required reviews for this PR has been set to 2 based on the presence of this label: rfr. This can be overridden with the /reviewers command.

@mlbridge

mlbridge Bot commented Aug 14, 2026

Copy link
Copy Markdown

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rfr Ready for review

Development

Successfully merging this pull request may close these issues.

1 participant