8359862: RichTextArea: prompt - #2237
Open
andy-goryachev-oracle wants to merge 4 commits into
Open
Conversation
|
👋 Welcome back angorya! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
andy-goryachev-oracle
marked this pull request as ready for review
August 3, 2026 20:13
|
@andy-goryachev-oracle an approved CSR request is already required for this pull request. |
|
The total number of required reviews for this PR has been set to 2 based on the presence of this label: |
Webrevs
|
Contributor
Author
|
@azuev-java @kevinrushforth could you review this PR please? |
kevinrushforth
self-requested a review
August 15, 2026 13:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
promptattribute to theRichTextArea, to be shown when the model isnullor empty.To allow for greater flexibility, the type of this property is
Object, and there is an additional setter that acceptsSupplier<Object>. The value of the property, or the value provided by theSupplier<Object>is interpreted as follows:null: the prompt is disabledNode: the node to be shownString: the text will be shown inside aLabelwith style.promptObject: the toString() value will be shown similarly to theStringvalueThe main idea is to have only one property and allow complex graphics to be shown.
Example:
/csr
Progress
Issues
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/2237/head:pull/2237$ git checkout pull/2237Update a local copy of the PR:
$ git checkout pull/2237$ git pull https://git.openjdk.org/jfx.git pull/2237/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2237View PR using the GUI difftool:
$ git pr show -t 2237Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/2237.diff
Using Webrev
Link to Webrev Comment