8388276: RichTextArea: image import - #2224
Conversation
|
👋 Welcome back angorya! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
@andy-goryachev-oracle has indicated that a compatibility and specification (CSR) request is needed for this pull request. @andy-goryachev-oracle please create a CSR request for issue JDK-8388276 with the correct fix version. This pull request cannot be integrated until the CSR request is approved. |
|
The total number of required reviews for this PR has been set to 2 based on the presence of this label: |
Webrevs
|
|
@arapte @kevinrushforth could you review this PR please? |
|
I've filed https://bugs.openjdk.org/browse/JDK-8390345 to avoid duplicating image i/o code. |
Enables importing of images from the clipboard into the RichTextModel by adding a data format handler for the DataFormat.IMAGE mime type.
This change includes fixes from #2254 applied to
ImgUtilclass whose purpose is to remove dependency onjavafx.swingmodule.Note: the banana slug image is a public domain added with author's permission [0].
References
[0] https://en.wikipedia.org/wiki/Banana_slug
/csr
Progress
Warnings
Issues
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/2224/head:pull/2224$ git checkout pull/2224Update a local copy of the PR:
$ git checkout pull/2224$ git pull https://git.openjdk.org/jfx.git pull/2224/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2224View PR using the GUI difftool:
$ git pr show -t 2224Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/2224.diff
Using Webrev
Link to Webrev Comment