Skip to content

8388276: RichTextArea: image import - #2224

Open
andy-goryachev-oracle wants to merge 10 commits into
openjdk:masterfrom
andy-goryachev-oracle:8388276.import.images
Open

8388276: RichTextArea: image import#2224
andy-goryachev-oracle wants to merge 10 commits into
openjdk:masterfrom
andy-goryachev-oracle:8388276.import.images

Conversation

@andy-goryachev-oracle

@andy-goryachev-oracle andy-goryachev-oracle commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Enables importing of images from the clipboard into the RichTextModel by adding a data format handler for the DataFormat.IMAGE mime type.

This change includes fixes from #2254 applied to ImgUtil class whose purpose is to remove dependency on javafx.swing module.

Note: the banana slug image is a public domain added with author's permission [0].

References

[0] https://en.wikipedia.org/wiki/Banana_slug

/csr



Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8389549 to be approved
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Warnings

 ⚠️ Patch contains a binary file (tests/system/src/test/resources/test/com/sun/javafx/images/banana-slug.jpg)
 ⚠️ Patch contains a binary file (tests/system/src/test/resources/test/com/sun/javafx/images/underlines.png)

Issues

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/2224/head:pull/2224
$ git checkout pull/2224

Update a local copy of the PR:
$ git checkout pull/2224
$ git pull https://git.openjdk.org/jfx.git pull/2224/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2224

View PR using the GUI difftool:
$ git pr show -t 2224

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/2224.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Jul 27, 2026

Copy link
Copy Markdown

👋 Welcome back angorya! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jul 27, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot added the csr Need approved CSR to integrate pull request label Jul 28, 2026
@openjdk

openjdk Bot commented Jul 28, 2026

Copy link
Copy Markdown

@andy-goryachev-oracle has indicated that a compatibility and specification (CSR) request is needed for this pull request.

@andy-goryachev-oracle please create a CSR request for issue JDK-8388276 with the correct fix version. This pull request cannot be integrated until the CSR request is approved.

@andy-goryachev-oracle
andy-goryachev-oracle marked this pull request as ready for review July 31, 2026 22:57
@openjdk openjdk Bot added the rfr Ready for review label Jul 31, 2026
@openjdk

openjdk Bot commented Jul 31, 2026

Copy link
Copy Markdown

The total number of required reviews for this PR has been set to 2 based on the presence of this label: rfr. This can be overridden with the /reviewers command.

@mlbridge

mlbridge Bot commented Jul 31, 2026

Copy link
Copy Markdown

Webrevs

@andy-goryachev-oracle

Copy link
Copy Markdown
Contributor Author

@arapte @kevinrushforth could you review this PR please?

@andy-goryachev-oracle

Copy link
Copy Markdown
Contributor Author

I've filed https://bugs.openjdk.org/browse/JDK-8390345 to avoid duplicating image i/o code.

@kevinrushforth
kevinrushforth self-requested a review August 15, 2026 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

csr Need approved CSR to integrate pull request rfr Ready for review

Development

Successfully merging this pull request may close these issues.

1 participant