Skip to content

8388304: Scene.setNodeOrientation triggers instant CSS but also doesn't update properly. #2213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FlorianKirmaier wants to merge 2 commits into
base: master
Choose a base branch
from
Open

8388304: Scene.setNodeOrientation triggers instant CSS but also doesn't update properly. #2213

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de51ff5
8388304: Scene.setNodeOrientation does not update :dir() styles
sandec-bot Jul 15, 2026
02eaa57
8388304: fixed spelling and test-name
sandec-bot Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/javafx.graphics/src/main/java/javafx/scene/Scene.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5876,7 +5876,7 @@ public final ObjectProperty<NodeOrientation> nodeOrientationProperty() {
@Override
protected void invalidated() {
sceneEffectiveOrientationInvalidated();
getRoot().applyCss();
getRoot().reapplyCSS();
}

@Override
Expand Down
37 changes: 36 additions & 1 deletion ...s/javafx.graphics/src/test/java/test/javafx/scene/Node_effectiveOrientation_Css_Test.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@
/**
* Test :dir functional pseudo-class
*/
@Disabled("JDK-8234152")
public class Node_effectiveOrientation_Css_Test {

private Group root;
Expand Down Expand Up @@ -119,6 +118,7 @@ public void test_SimpleSelector_dir_pseudoClass_with_scene_effective_orientation
assertEquals(Color.web("#ff0000"), rect.getFill());
}

@Disabled("JDK-8234152")
@Test
public void test_CompounSelector_dir_pseudoClass_on_parent_with_scene_effective_orientation_ltr() {
Stylesheet stylesheet = new CssParser().parse(
Expand All @@ -139,6 +139,8 @@ public void test_CompounSelector_dir_pseudoClass_on_parent_with_scene_effective_
assertEquals(Color.web("#00ff00"), rect.getFill());
}


@Disabled("JDK-8234152")
@Test
public void test_CompoundSelector_dir_pseudoClass_on_parent_with_scene_effective_orientation_rtl() {
Stylesheet stylesheet = new CssParser().parse(
Expand All @@ -160,6 +162,7 @@ public void test_CompoundSelector_dir_pseudoClass_on_parent_with_scene_effective
assertEquals(Color.web("#ff0000"), rect.getFill());
}

@Disabled("JDK-8234152")
@Test
public void test_CompounSelector_dir_pseudoClass_on_child_with_scene_effective_orientation_ltr() {

@Maran23 Maran23 Jul 17, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While here, can we fix the typo in test_Compoun -> test_Compound here and some other tests aswell

@FlorianKirmaier FlorianKirmaier Jul 23, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the 2 Compun - couldn't find another spelling error.

Stylesheet stylesheet = new CssParser().parse(
Expand All @@ -180,6 +183,7 @@ public void test_CompounSelector_dir_pseudoClass_on_child_with_scene_effective_o
assertEquals(Color.web("#00ff00"), rect.getFill());
}

@Disabled("JDK-8234152")
@Test
public void test_CompoundSelector_dir_pseudoClass_on_child_with_scene_effective_orientation_rtl() {
Stylesheet stylesheet = new CssParser().parse(
Expand Down Expand Up @@ -236,4 +240,35 @@ public void test_dir_pseudoClass_functions_on_scene_effective_orientation_not_no

}

@Test
public void testCssUpdates() {

@Maran23 Maran23 Jul 17, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should name it similar as what you wrote in your description - maybe testChangeNodeOrientationWillReapplyCss or testChangeNodeOrientationWillBatchReapplyCss

@FlorianKirmaier FlorianKirmaier Jul 23, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's now named testChangeNodeOrientationWillReapplyCss.

Group root = new Group();
Scene scene = new Scene(root);
Stage stage = new Stage();
stage.setScene(scene);
stage.show();

Stylesheet stylesheet = new CssParser().parse(
".rect:dir(rtl) { -fx-fill: #ff0000; }" +
".rect:dir(ltr) { -fx-fill: #00ff00; }" +
".rect { -fx-fill: #0000ff; }"
);
StyleManager.getInstance().setDefaultUserAgentStylesheet(stylesheet);

Rectangle rect = new Rectangle();
rect.getStyleClass().add("rect");
root.getChildren().add(rect);

root.applyCss();
assertEquals(Color.web("#00ff00"), rect.getFill());

scene.setNodeOrientation(RIGHT_TO_LEFT);
root.applyCss();
assertEquals(Color.web("#ff0000"), rect.getFill());

scene.setNodeOrientation(LEFT_TO_RIGHT);
root.applyCss();
assertEquals(Color.web("#00ff00"), rect.getFill());
}

}