Skip to content

fix: add the link to config schema for tuples in transactional writes and support it to by default info - #937

Merged
rhamzeh merged 7 commits into
openfga:mainfrom
afzal442:fix-tuple-val
Jul 14, 2026
Merged

fix: add the link to config schema for tuples in transactional writes and support it to by default info#937
rhamzeh merged 7 commits into
openfga:mainfrom
afzal442:fix-tuple-val

Conversation

@afzal442

@afzal442 afzal442 commented Jan 20, 2025

Copy link
Copy Markdown
Contributor

Closes: #815

Description

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

Summary by CodeRabbit

  • Documentation
    • Clarified the Write API tuple limit documentation to explicitly explain that the limit is configurable and applies to the combined sum of writes and deletes, with updated reference to configuration options.

✏️ Tip: You can customize this high-level summary in your review settings.

@afzal442
afzal442 requested a review from a team as a code owner January 20, 2025 16:46
@afzal442

Copy link
Copy Markdown
Contributor Author

cc @rhamzeh

@rhamzeh rhamzeh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @afzal442 - was avoiding merging until the new page was available, can I ask you to link to it now?

Comment thread docs/content/interacting/transactional-writes.mdx Outdated
@afzal442
afzal442 requested a review from rhamzeh March 11, 2025 17:37
rhamzeh
rhamzeh previously approved these changes Mar 11, 2025
@rhamzeh
rhamzeh enabled auto-merge (squash) March 11, 2025 17:39
@rhamzeh rhamzeh self-assigned this May 8, 2025
Comment thread docs/content/interacting/transactional-writes.mdx Outdated
auto-merge was automatically disabled November 24, 2025 05:23

Head branch was pushed to by a user without write access

@coderabbitai

coderabbitai Bot commented Nov 24, 2025

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 16a2dfdb-c4cc-496a-982d-9c752c13bcf1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Walkthrough

This PR corrects the transactional Write API tuple limit in documentation from 10 to 100, the actual default value. It clarifies the limit is configurable via --max-tuples-per-write and adds a link to the configuration schema documentation.

Changes

Cohort / File(s) Summary
Documentation Update
docs/content/interacting/transactional-writes.mdx
Updated Write API tuple limit description from 10 to 100 (default), added configurable flag reference (--max-tuples-per-write), and linked to configuration schema documentation

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Single documentation file with a straightforward factual correction and clarification

Possibly related PRs

Suggested reviewers

  • rhamzeh

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title is partially related but unclear—it mentions adding a config link and 'support it to by default info' which are vague; unclear grammar makes the primary objective hard to discern. Clarify the title to directly state the change: 'fix: correct tuple limit from 10 to 100 and add config schema link' or similar.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed The PR addresses all requirements from issue #815: corrects the tuple limit default value, indicates configurability, and adds documentation link to config schema.
Out of Scope Changes check ✅ Passed All changes are directly scoped to the issue requirements: documentation updates to transactional-writes.mdx regarding tuple limits and configurability.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@curfew-marathon

Copy link
Copy Markdown
Contributor

This PR has had no human activity for 90 days, so it has been marked lifecycle/stale.

This is automated backlog grooming, not a judgment on the work.

What happens next, unless there is activity:

  • In 30 days, it will move to lifecycle/closing-soon
  • 30 days after that, it will be closed

To keep it open, push a commit or leave a comment, and the clock will reset. For work that should not auto-close, such as an RFC or long-running experiment, ask a maintainer to add lifecycle/frozen.

@curfew-marathon curfew-marathon added the lifecycle/stale No human activity in 90 days label Jul 3, 2026
Copilot AI review requested due to automatic review settings July 14, 2026 15:44

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@rhamzeh
rhamzeh enabled auto-merge (squash) July 14, 2026 15:44
@rhamzeh
rhamzeh disabled auto-merge July 14, 2026 15:44
@rhamzeh
rhamzeh enabled auto-merge (squash) July 14, 2026 15:44
@rhamzeh
rhamzeh merged commit 0a26e22 into openfga:main Jul 14, 2026
11 checks passed
@afzal442
afzal442 deleted the fix-tuple-val branch July 14, 2026 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lifecycle/stale No human activity in 90 days

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Value for tuples in transactional writes is incorrect

5 participants