Update the description of ip-ttl and dscp - #1511
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Code Review
This pull request updates the descriptions for the dscp and ip-ttl leaves in openconfig-aft-common.yang to clarify encapsulation behavior. The review feedback correctly identifies a syntax error in the dscp description caused by a curly double quote, as well as capitalization and spacing inconsistencies regarding 'Hop Limit' in the ip-ttl description.
1deda9e to
7825e90
Compare
7825e90 to
64a0e50
Compare
|
OC operator review July 14th. Thanks for your contribution. Can you add references to this in the PR description? Do we have an RFC that specifics this or 2 vendor implementations that support this behavior? |
|
OC review 28th. Added a few comments, + requesting for supporting implementations from 2 vendors. Can you please sign this to ensure the check passes [ this is a presubmit check] |
Update the description of the following leaves:
ip-ttl: Since this leave models both TTL (IPv4) and Hop Limit (IPv6) values, then, we need to indicate this explicitly in the leaf's description.dscp: Update the description of the behavior when the leaf is not configured. When the leaf is not configured, the value of the inner packet will be copied over as the outer packet's value during encapsulation.