Skip to content

Update the description of ip-ttl and dscp - #1511

Open
tasaleh wants to merge 2 commits into
openconfig:masterfrom
tasaleh:ip_ttl_dscp_description_update
Open

Update the description of ip-ttl and dscp#1511
tasaleh wants to merge 2 commits into
openconfig:masterfrom
tasaleh:ip_ttl_dscp_description_update

Conversation

@tasaleh

@tasaleh tasaleh commented Jul 7, 2026

Copy link
Copy Markdown

Update the description of the following leaves:

ip-ttl: Since this leave models both TTL (IPv4) and Hop Limit (IPv6) values, then, we need to indicate this explicitly in the leaf's description.

dscp: Update the description of the behavior when the leaf is not configured. When the leaf is not configured, the value of the inner packet will be copied over as the outer packet's value during encapsulation.

@tasaleh
tasaleh requested a review from a team as a code owner July 7, 2026 18:39
@google-cla

google-cla Bot commented Jul 7, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the descriptions for the dscp and ip-ttl leaves in openconfig-aft-common.yang to clarify encapsulation behavior. The review feedback correctly identifies a syntax error in the dscp description caused by a curly double quote, as well as capitalization and spacing inconsistencies regarding 'Hop Limit' in the ip-ttl description.

Comment thread release/models/aft/openconfig-aft-common.yang Outdated
Comment thread release/models/aft/openconfig-aft-common.yang Outdated
@tasaleh
tasaleh force-pushed the ip_ttl_dscp_description_update branch from 1deda9e to 7825e90 Compare July 7, 2026 18:54
@navaneethyv navaneethyv moved this to Ready to discuss in OC Operator Review Jul 14, 2026
@navaneethyv

Copy link
Copy Markdown
Contributor

OC operator review July 14th.

Thanks for your contribution.

Can you add references to this in the PR description? Do we have an RFC that specifics this or 2 vendor implementations that support this behavior?

Comment thread release/models/aft/openconfig-aft-common.yang
Comment thread release/models/aft/openconfig-aft-common.yang
@navaneethyv

navaneethyv commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

OC review 28th.

Added a few comments, + requesting for supporting implementations from 2 vendors.

Can you please sign this to ensure the check passes [ this is a presubmit check]
https://github.com/openconfig/public/pull/1511/checks?check_run_id=87139774474

Comment thread release/models/aft/openconfig-aft-common.yang
Comment thread release/models/aft/openconfig-aft-common.yang
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

5 participants