Skip to content

juniper: handle rare exception and increase timeout #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nitinsoniism wants to merge 2 commits into
base: main
Choose a base branch
from
Open

juniper: handle rare exception and increase timeout #622

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e7b1f7
juniper:
nitinsoniism May 20, 2025
cb64bce
Merge branch 'main' into juniper_scrapli_timeout
kraney Aug 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions topo/node/juniper/juniper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ var (
// For committing a very large config
scrapliOperationTimeout = 300 * time.Second
// Wait for PKI cert infra
certGenTimeout = 10 * time.Minute
certGenTimeout = 15 * time.Minute
// Time between polls
certGenRetrySleep = 30 * time.Second
// Wait for config mode
Expand Down Expand Up @@ -130,7 +130,7 @@ func (n *Node) waitConfigInfraReadyAndPushConfigs(configs []string) error {
for time.Since(start) < configModeTimeout {
multiresp, err := n.cliConn.SendConfigs(configs)
Comment thread
marcushines marked this conversation as resolved.
if err != nil {
if strings.Contains(err.Error(), "errPrivilegeError") {
if strings.Contains(err.Error(), "errPrivilegeError") || strings.Contains(err.Error(), "errTimeoutError") {
log.Infof("Config mode not ready. Retrying in %v. Node %s, Resp %v", configModeRetrySleep, n.Name(), err)
} else {
return fmt.Errorf("failed pushing configs: %v", err)
Expand Down