Skip to content

gnoi/os: update comment for package_size to note the field is recommended #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brianneville wants to merge 3 commits into
base: main
Choose a base branch
from
Open

gnoi/os: update comment for package_size to note the field is recommended #302

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dc4bf91
gnoi/os: make package_size required.
brianneville Sep 4, 2025
ff45888
gnoi/os: update comment to note that the package_size is not required…
brianneville Sep 11, 2025
dd9be7b
reword comment
brianneville Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions os/os.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,8 @@ message TransferRequest {
// and 2) the required space in the Target is larger than the available space
// and 3) the Target is unable to release space for the incoming OS package,
// then the Target must reply with InstallError->Type->TOO_LARGE.
// It is recommended that this field be set, so that the Target can
// free up space more precisely.
uint64 package_size = 3;
}

Expand Down
Loading