Repository navigation
feat: add blend cloudcasting forecast model to GB national models #417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -244,6 +244,12 @@ class FM: | |
| adjust_name="blend_adjust", | ||
| adjust_aliases=("blend_adjust",), | ||
| ) | ||
| # GB — blend cloudcasting | ||
| BLEND_CLOUDCASTING = ForecastModel( | ||
| name="blend_cloudcasting", | ||
| label="Blend Cloudcasting", | ||
| adjust_name="blend_cloudcasting_adjust", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. question: did we say we were only going to have the adjusted version of this @peterdudfield? I can't remember now
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should have atleast the adjusted version as its more accurate. I dont know if we have the option to not show the un-adjusted version?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We don't currently, if there's a strong reason to not give the unadjusted version then we can, but otherwise this should be fine |
||
| ) | ||
| # GB — NWP-only day-ahead (ECMWF + Met Office, no satellite at day-ahead range) | ||
| ECMWF_MO = ForecastModel( | ||
| name="pvnet_day_ahead", | ||
|
|
@@ -351,6 +357,7 @@ class FM: | |
| FM.ECMWF, | ||
| FM.SAT_8H, | ||
| FM.MO, | ||
| FM.BLEND_CLOUDCASTING, | ||
| ) | ||
|
|
||
| _GB_GSP_FORECAST_MODELS = ( | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe "Blend + Cloudcasting" or "Blend with Cloudcasting"