Repository navigation
Graceful fail for summation model in backtest - #546
Merged
Merged
Conversation
Added a noqa comment to suppress a linting warning for the exception handling.
Added use_summation_model parameter to BacktestStreamedDataset and updated sample generation logic to conditionally include national capacity.
Sukh-P
reviewed
Sep 16, 2026
Member
|
I think this looks good @felix-e-h-p, wondering if it would be easy enough to run it without a summation model defined to check it's working properly |
Sukh-P
approved these changes
Sep 16, 2026
Sukh-P
left a comment
Sukh-P
left a comment
Member
There was a problem hiding this comment.
Looks good but as mentioned would be great if this could be ran (with/without summation) just to double check it's all good since we lack tests for scripts
Contributor
Author
|
Ran on NL model (pvnet 6815348c), with summation (f2b9b22e) and without. Both runs fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relating to not using a summation model and no national i.e. 0 location in target - so specific regional backtests for NL. Graceful fail mode. Please correct me if wrong @bsharma58