Repository navigation
feat: support reading tilt and orientation from Data Platform metadat… - #135
Merged
Merged
Conversation
…a with database fallback
PavanRaghavendraKulkarni
marked this pull request as ready for review
September 2, 2026 07:06
Contributor
|
Contributor
Author
peterdudfield
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Pull Request
Description
Adds support for reading
tilt/orientationfrom Data Platform location metadata, falling back to the database when a location hasn't been backfilled with that metadata yet (or isn't found in DP at all). This is a prerequisite for eventually eliminating the database dependency entirely (see the follow-up PR, "Stripping out the datamodel") — DP has no native field for tilt/orientation, so they have to be read from each location'smetadataStruct, written there bypv-site-api'screate_location/update_location.DbPvDataSource.get()now prefers DP-sourced tilt/orientation when present in a location's metadata, falling back to the site database'stilt/orientationcolumns otherwise — so behavior is unchanged for any site not yet backfilled in DP.Fixes #
How Has This Been Tested?
Added unit tests covering: DP metadata present (used), DP metadata absent (falls back to DB), site not found in DP at all (falls back to DB)
Full existing test suite still passing
This one tested against the dev platform
Yes
Checklist: