fix: show published versions after pending releases - #3691
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
@goutamadwant is attempting to deploy a commit to the OpenClaw Foundation Team on Vercel. A member of the Team first needs to authorize it. |
|
Codex review: needs real behavior proof before merge. Reviewed September 14, 2026, 9:59 AM ET / 13:59 UTC. ClawSweeper reviewWhat this changesThe PR filters unpublished and deleted package releases before a single Convex pagination call and adds regression coverage for published and legacy versions. Merge readiness⛔ Blocked before merge - 4 items remain Keep open: the pagination defect remains on main and in v0.23.3. This is a focused repair, but it removes an existing page-size guard and still needs real-runtime proof. Priority: P2 Review scores
Verification
How this fits togetherClawHub’s version-history queries read stored package releases for the HTTP API and plugin details interface. They enforce package visibility and return published versions with continuation cursors. flowchart LR
A[Version history request] --> B[Package visibility check]
B --> C[Package release index]
C --> D[Published and active filter]
D --> E[Single pagination operation]
E --> F[Versions and continuation cursor]
Before merge
Findings
Agent review detailsSecurityNone. Review metrics
Root-cause clusterRelationship: Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Keep one native pagination operation in the shared query while preserving bounded requests, release visibility, legacy records, and native continuation metadata. Do we have a high-confidence way to reproduce the issue? Yes, from source: requesting one version when a pending release precedes a published release reaches a second native pagination call on main, which Convex rejects. This review did not execute the fixture. Is this the best way to solve the issue? The shared-query repair is the right layer, but the patch should retain the existing request bound. Client retries cannot fix the deterministic backend error, and a schema migration is unnecessary for this focused repair. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 8c2de6c506bb. LabelsLabel changes:
Label justifications:
EvidenceWhat I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
|
Closes #3687
What Problem This Solves
Fixes an issue where users opening version history for packages with an unpublished newest release would receive an HTTP 500 response instead of the available published versions.
Why This Change Was Made
The shared package-version query now applies publication and owner-deletion filters before one native Convex pagination operation. This preserves opaque cursor behavior and continues to include both explicit published releases and legacy releases without a publication status.
User Impact
Package version history remains available when a newer release is still pending, while pending, blocked, soft-deleted, and owner-deleted releases remain hidden.
Evidence
Before the fix, the focused regression reaches a second native pagination call and fails with
A query can only invoke paginate once.After the fix:
Validation:
Limitation: production request traces were not available, so this source-proven pagination defect may not explain every reported package-specific 500.
Disclosure: AI was used to understand the codebase and review the fix.