ci: shard local-auth Playwright gate - #2743
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
playwright-local-authgate into one matrix shard per local-auth spec, with the shared publish lifecycle spec split by grep so each shard runs one test path.playwright-local-authcheck name as a lightweight aggregate job over the matrix.RCA / Intent
The last-run pattern points more at slowness than nondeterministic test behavior: the long pole is the monolithic local-auth job doing repeated setup plus all signed-in browser flows serially. Sharding makes the gate parallel and the aggregate job keeps branch protection semantics stable.
Validation
actionlint .github/workflows/ci.ymlgit diff --checkbun run format:check -- .github/workflows/ci.ymlbun run ci:staticPLAYWRIGHT_LOCAL_AUTH_CONVEX_URL=http://127.0.0.1:3410 PLAYWRIGHT_LOCAL_AUTH_CONVEX_SITE_URL=http://127.0.0.1:3411 PLAYWRIGHT_PORT=4373 bun run test:pw:local-auth -- --project=chromium e2e/local-auth/header-profile-link.pw.test.tsPLAYWRIGHT_LOCAL_AUTH_CONVEX_URL=http://127.0.0.1:3420 PLAYWRIGHT_LOCAL_AUTH_CONVEX_SITE_URL=http://127.0.0.1:3421 PLAYWRIGHT_PORT=4383 bun run test:pw:local-auth -- --project=chromium e2e/local-auth/publish-skill-lifecycle.pw.test.ts --grep "publishing a skill queues scan".agents/skills/autoreview/scripts/autoreview --mode local