Repository navigation
fix(testreport): one openQA install log per flavor, kept byte-for-byte - #673
Merged
Merged
Conversation
An incident has several install jobs per distri/version/arch that differ only in flavor (plain, SAP, HA, TERADATA). The export named logs `<distri>_<version>_<arch>.log`, so those jobs collided on one name: the first job won the plain file and every divergent one was redirected to a fresh timestamped sibling. Each later export added another sibling, and `commit` uploaded them all as artifacts. The document scenario had the same gap, so distinct jobs looked identical in `testing.openqa.install`. `URLs` now carries the job flavor. Logs are named with it when set, and the scenario names it too. They come from the server and are never hand-edited, so they are rewritten in place instead of going through the overwrite prompt; manual host logs keep it.
The downloader split each log into lines that kept their trailing `\n`, and the writer then joined them with `\n` again, so every line break in the written log was doubled. The log is now written exactly as downloaded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
An incident has several openQA install jobs per distri/version/arch that differ only in flavor (plain, SAP, HA, TERADATA).
exportnamed their logs identically, so every export added timestamped copies thatcommitthen uploaded. The logs were also written with every line break doubled.Changes
URLscarries the openQA job flavor, taken from the dashboard job.<distri>_<version>_<arch>[_<flavor>].log; an empty flavor keeps the old name.testing.openqa.installscenarios are<distri>_<version>_<arch>[_<flavor>], so distinct jobs no longer look identical.\nis removed.Scenarios no longer match the pipeline's
distri_version_archkey. Anything server-side keyed on that string would diverge, so TeReGen may want to adopt the flavor too.Timestamped copies already on disk or in TeReGen are not cleaned up by mtui and need removing by hand.
Checklist
cargo fmt --all --checkis clean.cargo clippy --workspace --all-targets --all-features -- -D warningsis clean.cargo test --workspacepasses.cargo build --workspace --no-default-featuresand--all-features.CHANGELOG.md.docs/src/updated where relevant; no generated pages are affected.The new tests (flavor-specific file names, in-place rewrite on repeat export, flavor-specific scenarios, byte-exact log) were each run against the old behavior and failed there.