Repository navigation
fix(core): export writes the openqa_overview results into the report document - #672
Merged
Merged
Conversation
…document `export` passed `openqa().overview` to the authoring step, but nothing ever set that field: `openqa_overview` printed its result and dropped it, and only `--export` authored it. Running `openqa_overview` and then `export` therefore left `testing.openqa.extra` without single incidents, aggregated updates and build checks, for every workflow. `openqa_overview` now saves its full, not row-limited, result on the report. `export` writes the saved result and fetches one with the command's defaults when none is saved. A failed fetch prints a warning and the export continues without those rows, as the Manual workflow's dashboard fetch already does. The fetch moves into `fetch_overview` so both commands share it. The `--export` help no longer refers to the removed text log.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
exportreadsopenqa().overviewand authors it intotesting.openqa.extra, but nothing ever set that field.openqa_overviewprinted its result and dropped it; onlyopenqa_overview --exportauthored it. Runningopenqa_overviewand thenexportleft the single incidents, aggregated updates and build checks out of the document, for every workflow (Auto, Kernel, Manual).Change
openqa_overviewsaves its full (not row-limited) result on the report, with or without--export.exportwrites the saved result. When none is saved it fetches one withopenqa_overview's defaults (5 days, groupcore, aggregated included, URLs from config).WARNING: openQA overview unavailable: <err>and the export continues without those rows. This matches the Manual workflow's existing dashboard fetch.fetch_overviewso both commands share it.openqa_overviewoutput is unchanged.--exporthelp no longer refers to the removed text log. This changes the MCP slim schema description foropenqa_overview.export.Tests
overview_then_export_authors_testing_openqa_extra: runs both commands in sequence. Red before the fix.export_fetches_overview_when_none_saved,export_reuses_saved_overview(the overview endpoints get zero requests),export_overview_fetch_failure_still_exports,overview_is_saved_on_the_report.I observed the new tests red by removing the save assignment and the saved-result guard.
Notes
openqa_overviewnow treats an emptysingle_incidentsas "no openQA builds yet". That is exact today becausesingle_incidentsreturns one row per version.client.confnow shows theOpenQA:header before its error, because the client is built insidefetch_overview.Local gate green: fmt, clippy
--all-features -D warnings, rustdoc-D warnings,cargo test --workspace,cargo test -p mtui-mcp -F mcp, and both feature builds.