Skip to content

fix(core): export writes the openqa_overview results into the report document - #672

Merged
mimi1vx merged 1 commit into
openSUSE:mainfrom
mimi1vx:fix/export-openqa-overview
Oct 8, 2026
Merged

mimi1vx merged 1 commit into
openSUSE:mainfrom
mimi1vx:fix/export-openqa-overview

Conversation

@mimi1vx

@mimi1vx mimi1vx commented Oct 8, 2026

Copy link
Copy Markdown
Member

Problem

export reads openqa().overview and authors it into testing.openqa.extra, but nothing ever set that field. openqa_overview printed its result and dropped it; only openqa_overview --export authored it. Running openqa_overview and then export left the single incidents, aggregated updates and build checks out of the document, for every workflow (Auto, Kernel, Manual).

Change

  • openqa_overview saves its full (not row-limited) result on the report, with or without --export.
  • export writes the saved result. When none is saved it fetches one with openqa_overview's defaults (5 days, group core, aggregated included, URLs from config).
  • A failed fetch prints WARNING: openQA overview unavailable: <err> and the export continues without those rows. This matches the Manual workflow's existing dashboard fetch.
  • The fetch moved into fetch_overview so both commands share it. openqa_overview output is unchanged.
  • The --export help no longer refers to the removed text log. This changes the MCP slim schema description for openqa_overview.export.

Tests

  • overview_then_export_authors_testing_openqa_extra: runs both commands in sequence. Red before the fix.
  • export_fetches_overview_when_none_saved, export_reuses_saved_overview (the overview endpoints get zero requests), export_overview_fetch_failure_still_exports, overview_is_saved_on_the_report.
  • Existing export tests seed an empty overview so they never reach production URLs.

I observed the new tests red by removing the save assignment and the saved-result guard.

Notes

  • openqa_overview now treats an empty single_incidents as "no openQA builds yet". That is exact today because single_incidents returns one row per version.
  • A malformed openQA client.conf now shows the OpenQA: header before its error, because the client is built inside fetch_overview.

Local gate green: fmt, clippy --all-features -D warnings, rustdoc -D warnings, cargo test --workspace, cargo test -p mtui-mcp -F mcp, and both feature builds.

…document

`export` passed `openqa().overview` to the authoring step, but nothing ever
set that field: `openqa_overview` printed its result and dropped it, and only
`--export` authored it. Running `openqa_overview` and then `export` therefore
left `testing.openqa.extra` without single incidents, aggregated updates and
build checks, for every workflow.

`openqa_overview` now saves its full, not row-limited, result on the report.
`export` writes the saved result and fetches one with the command's defaults
when none is saved. A failed fetch prints a warning and the export continues
without those rows, as the Manual workflow's dashboard fetch already does.

The fetch moves into `fetch_overview` so both commands share it. The
`--export` help no longer refers to the removed text log.
@mimi1vx
mimi1vx merged commit d0e0f60 into openSUSE:main Oct 8, 2026
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant