Skip to content

feat(i18n): add Azerbaijani (az) locale - #4029

Merged
IOhacker merged 2 commits into
openMF:devfrom
jamalkamaladdin:feat/az-locale
Sep 25, 2026
Merged

IOhacker merged 2 commits into
openMF:devfrom
jamalkamaladdin:feat/az-locale

Conversation

@jamalkamaladdin

@jamalkamaladdin jamalkamaladdin commented Sep 21, 2026 •

Copy link
Copy Markdown
Member

Description

New file src/assets/translations/az-AZ.json: 6150 strings, all filled in.
src/environments/environment.ts and src/environments/environment.prod.ts: added az-AZ to the default supportedLanguages list.
README.md: added an Azerbaijani row to the available languages table and az-AZ to the MIFOS_SUPPORTED_LANGUAGES example values.
docker-compose.yml: added az-AZ to the MIFOS_SUPPORTED_LANGUAGES environment variable.
src/app/core/utils/translations.spec.ts, src/app/clients/web-1131-address-line-translations.spec.ts, src/app/core/translation/web-1101-account-menu-translations.spec.ts and src/app/organization/exchange-rates/web-1070-translations.spec.ts: added az-AZ to the locale lists these existing tests already run against.

Related issues and discussion

No Jira ticket for this change.

Screenshots, if any

None, this change only touches translation and locale configuration files.

Checklist

  • If you have multiple commits please combine them into one commit by squashing them.

  • Read and understood the contribution guidelines at web-app/.github/CONTRIBUTING.md.

Summary by CodeRabbit

  • New Features

    • Added Azerbaijani (az-AZ) as a supported application language.
    • Azerbaijani is now included in language settings and available-language listings.
    • Azerbaijani translations are included for address details, account menus, transfer fees, exchange rates, and validation messages.
  • Tests

    • Added Azerbaijani coverage to translation completeness and localized interface tests.

@jamalkamaladdin
jamalkamaladdin requested a review from a team September 21, 2026 23:15
@mifos-cla-check

Copy link
Copy Markdown

👋 Hi @jamalkamaladdin — thank you for your pull request.

This PR is currently blocked because we do not have a Contributor License Agreement (CLA) on file for your GitHub account.

To get unblocked:

  1. Complete the form at https://mifos.org/about-us/financial-legal/mifos-contributor-agreement
  2. Complete the CLA signing process
  3. Once verified you will be added to the approved contributors list and this PR check will be cleared

@mifos-cla-check mifos-cla-check Bot added the cla-required CLA signature required before this PR can be merged label Sep 21, 2026
@coderabbitai

coderabbitai Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

Understand this PR’s impact

Explore downstream dependencies and potential security impact with Blast Radius.

View blast radius →

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⚙️ Run configuration

Configuration used: Repository: openMF/web-app/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: ad577885-4447-443c-a921-70db62e2fcb3

📥 Commits

Reviewing files that changed from the base of the PR and between f859311 and a2a3a8b.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)
Validation error: Unrecognized key: "pre_merge_checks"
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openMF/web-app/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: b00cb18d-f243-4058-8f92-ce978f52d455

📥 Commits

Reviewing files that changed from the base of the PR and between d4a4c9c and aef3394.

📒 Files selected for processing (9)
  • README.md
  • docker-compose.yml
  • src/app/clients/web-1131-address-line-translations.spec.ts
  • src/app/core/translation/web-1101-account-menu-translations.spec.ts
  • src/app/core/utils/translations.spec.ts
  • src/app/organization/exchange-rates/web-1070-translations.spec.ts
  • src/assets/translations/az-AZ.json
  • src/environments/environment.prod.ts
  • src/environments/environment.ts

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


Walkthrough

The PR adds Azerbaijani (az-AZ) to default language configuration, README language lists, and translation test coverage.

Changes

Azerbaijani language support

Layer / File(s) Summary
Language configuration defaults
src/environments/environment.ts, src/environments/environment.prod.ts, docker-compose.yml
Default supported-language lists now prepend az-AZ.
Language documentation
README.md
The README lists Azerbaijani in sandbox settings, language settings, and the available languages table.
Translation test coverage
src/app/clients/*, src/app/core/translation/*, src/app/core/utils/*, src/app/organization/exchange-rates/*
Translation tests now include Azerbaijani locale files and its expected invalid-JSON message.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Feature

Suggested reviewers: iohacker, anvaykharb

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding Azerbaijani (az) localization support. It matches the pull request objectives and changed files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 6…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@IOhacker

Copy link
Copy Markdown
Contributor

@jamalkamaladdin Complete the form at https://mifos.org/about-us/financial-legal/mifos-contributor-agreement
Complete the CLA signing process
Once verified you will be added to the approved contributors list and this PR check will be cleared

@jamalkamaladdin

Copy link
Copy Markdown
Member Author

@IOhacker completed 2 times )

@IOhacker

IOhacker commented Sep 23, 2026 via email

Copy link
Copy Markdown
Contributor

@jamalkamaladdin

Copy link
Copy Markdown
Member Author

not received

@DavidMifosA

Copy link
Copy Markdown
Contributor

@jamalkamaladdin it was sent, it may be in your junk, it comes from GitHub and you need to click the link. I have initiated a resend so it should be very recent.

@jamalkamaladdin

Copy link
Copy Markdown
Member Author

done

@mifos-cla-check mifos-cla-check Bot removed the cla-required CLA signature required before this PR can be merged label Sep 24, 2026
@IOhacker
IOhacker merged commit abf0a71 into openMF:dev Sep 25, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants